Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1440173002: Update MB for the new way to run 'analyze'. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
sky, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update MB for the new way to run 'analyze'. Calling `mb analyze` will now get two lists of targets passed in instead of one, and return two differently named lists as output. See the updated docs or the bug for details. The code currently supports both new and old interfaces, but we'll remove the old interface once the recipes have been updated. R=sky@chromium.org, phajdan.jr@chromium.org BUG=552146 Committed: https://crrev.com/5ab84a5078142353428eb669e3ecf7ade00da57e Cr-Commit-Position: refs/heads/master@{#359575}

Patch Set 1 : original patch for review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -29 lines) Patch
M tools/mb/docs/design_spec.md View 1 chunk +5 lines, -2 lines 2 comments Download
M tools/mb/mb.py View 5 chunks +70 lines, -27 lines 0 comments Download
M tools/mb/mb_unittest.py View 3 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440173002/20001
5 years, 1 month ago (2015-11-13 02:14:24 UTC) #5
Dirk Pranke
https://codereview.chromium.org/1440173002/diff/20001/tools/mb/docs/design_spec.md File tools/mb/docs/design_spec.md (right): https://codereview.chromium.org/1440173002/diff/20001/tools/mb/docs/design_spec.md#newcode194 tools/mb/docs/design_spec.md:194: in that case. sky@, you might want to double-check ...
5 years, 1 month ago (2015-11-13 02:14:28 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/145904)
5 years, 1 month ago (2015-11-13 02:19:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440173002/20001
5 years, 1 month ago (2015-11-13 02:52:16 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-13 02:52:17 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440173002/20001
5 years, 1 month ago (2015-11-13 03:25:18 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 04:04:08 UTC) #16
Paweł Hajdan Jr.
LGTM
5 years, 1 month ago (2015-11-13 12:34:07 UTC) #17
sky
https://codereview.chromium.org/1440173002/diff/20001/tools/mb/docs/design_spec.md File tools/mb/docs/design_spec.md (right): https://codereview.chromium.org/1440173002/diff/20001/tools/mb/docs/design_spec.md#newcode194 tools/mb/docs/design_spec.md:194: in that case. On 2015/11/13 02:14:28, Dirk Pranke wrote: ...
5 years, 1 month ago (2015-11-13 16:26:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440173002/20001
5 years, 1 month ago (2015-11-13 17:29:25 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-13 17:35:09 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 17:37:08 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ab84a5078142353428eb669e3ecf7ade00da57e
Cr-Commit-Position: refs/heads/master@{#359575}

Powered by Google App Engine
This is Rietveld 408576698