tools/mb/docs/design_spec.md - Issue 1440173002: Update MB for the new way to run 'analyze'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/docs/design_spec.md

Issue 1440173002: Update MB for the new way to run 'analyze'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: original patch for review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/docs/design_spec.md

diff --git a/tools/mb/docs/design_spec.md b/tools/mb/docs/design_spec.md

index 55f8c794d2bfb0680c3765094b4e5add67e79be8..525a02b0672a127b075df7a94a9a58e8357424d1 100644

--- a/tools/mb/docs/design_spec.md

+++ b/tools/mb/docs/design_spec.md

@@ -187,8 +187,11 @@ treat this as an error, if so desired.

Any of the three inputs may be an empty list:

-* It doesn't make sense to call analyze at all if no files were modified,

- so this should probably return an error.

+* It normally doesn't make sense to call analyze at all if no files

+ were modified, but in rare cases we can hit a race where we try to

+ test a patch after it has already been committed, in which case

+ the list of modified files is empty. We should return 'no dependency'

+ in that case.

Dirk Pranke 2015/11/13 02:14:28 sky@, you might want to double-check that GYP hand

sky 2015/11/13 16:26:49 GYP ends up generating an error in this case. I do

* Passing an empty list for one or the other of test_targets and

additional_compile_targets is perfectly sensible: in the former case,

« no previous file with comments | « no previous file | tools/mb/mb.py » ('j') | no next file with comments »