Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1440163005: Allow users to customize the sanity-checking regexes (Closed)

Created:
5 years, 1 month ago by smut
Modified:
5 years, 1 month ago
Reviewers:
Sergey Berezin, agable
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Allow users to customize the sanity-checking regexes This doesn't add security, but at least allows users to open up the regexes where it's safe to do so. Fixes #985. Tested by hand. Patched from https://github.com/buildbot/buildbot/commit/cea9873e7fbe793720e55043c1c7fc4aebff0bd9. BUG=541449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M third_party/buildbot_8_4p1/buildbot/config.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/master.py View 3 chunks +18 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/base.py View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/builder.py View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/words.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
smut
I've added you as a reviewer because you're in the git log for people who ...
5 years, 1 month ago (2015-11-13 22:02:03 UTC) #4
Sergey Berezin
I can't claim to fully understand the code, but if it works and is part ...
5 years, 1 month ago (2015-11-13 22:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440163005/1
5 years, 1 month ago (2015-11-13 22:37:42 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 22:56:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297551

Powered by Google App Engine
This is Rietveld 408576698