Allow users to customize the sanity-checking regexes

third_party/buildbot_8_4p1/buildbot/master.py

 # This file is part of Buildbot.  Buildbot is free software: you can
 # redistribute it and/or modify it under the terms of the GNU General Public
 # License as published by the Free Software Foundation, version 2.
 #
 # This program is distributed in the hope that it will be useful, but WITHOUT
 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 # FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
 # details.
 #
 # You should have received a copy of the GNU General Public License along with
 # this program; if not, write to the Free Software Foundation, Inc., 51
 # Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 # Copyright Buildbot Team Members
 
 
+import re
 import os
 import signal
 import time
 import textwrap
 import twisted.internet.error
 
 try:
   import pyximport
   pyximport.install()
   from twisted.internet import epollreactor
@@ skipping 321 matching lines @@
                 changeHorizon = config.get("changeHorizon")
                 if changeHorizon is not None and not isinstance(changeHorizon, int):
                     raise ValueError("changeHorizon needs to be an int")
 
                 multiMaster = config.get("multiMaster", False)
 
                 metrics_config = config.get("metrics")
                 caches_config = config.get("caches", {})
                 autoBuildCacheRatio = config.get("autoBuildCacheRatio", None)
 
+                # load validation, with defaults, and verify no unrecognized
+                # keys are included.
+                validation_defaults = {
+                    'branch': re.compile(r'^[\w.+/~-]*$'),
+                    'revision': re.compile(r'^[\w.+/~-]*$'),
+                    'property_name': re.compile(r'^[\w\.\-\/\~:]*$'),
+                    'property_value': re.compile(r'^[\w\.\-\/\~:]*$'),
+                }
+                validation_config = validation_defaults.copy()
+                validation_config.update(config.get("validation", {}))
+                v_config_keys = set(validation_config.keys())
+                v_default_keys = set(validation_defaults.keys())
+                if v_config_keys > v_default_keys:
+                  raise ValueError("unrecognized validation key(s): %s" %
+                          (", ".join(v_config_keys - v_default_keys,)))
+
             except KeyError:
                 log.msg("config dictionary is missing a required parameter")
                 log.msg("leaving old configuration in place")
                 raise
 
             if "sources" in config:
                 m = ("c['sources'] is deprecated as of 0.7.6 and is no longer "
                      "accepted in >= 0.8.0 . Please use c['change_source'] instead.")
                 raise KeyError(m)
 
             if "bots" in config:
                 m = ("c['bots'] is deprecated as of 0.7.6 and is no longer "
                      "accepted in >= 0.8.0 . Please use c['slaves'] instead.")
                 raise KeyError(m)
 
             # Set up metrics and caches
             self.loadConfig_Metrics(metrics_config)
             self.loadConfig_Caches(caches_config, buildCacheSize,
                                    changeCacheSize)
 
             slaves = config.get('slaves', [])
             if "slaves" not in config:
                 log.msg("config dictionary must have a 'slaves' key")
                 log.msg("leaving old configuration in place")
                 raise KeyError("must have a 'slaves' key")
 
             self.config.changeHorizon = changeHorizon
+            self.config.validation = validation_config
 
             change_source = config.get('change_source', [])
             if isinstance(change_source, (list, tuple)):
                 change_sources = change_source
             else:
                 change_sources = [change_source]
 
             # do some validation first
             for s in slaves:
                 assert interfaces.IBuildSlave.providedBy(s)
@@ skipping 898 matching lines @@
         self.master.addChange(change)
 
     def addBuildset(self, **kwargs):
         return self.master.addBuildset(**kwargs)
 
     def getBuilder(self, name):
         b = self.master.botmaster.builders[name]
         return BuilderControl(b, self)
 
 components.registerAdapter(Control, BuildMaster, interfaces.IControl)