Dart: Avoid MojoResult and MojoHandleSignals constructors.

Dart: Avoid MojoResult and MojoHandleSignals constructors.

These take ~2ms to compile each.

BUG=
R=johnmccutchan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/de50f4d53f7cff0def5f4fbe8a1d0fb6f0ef39de

[zra, 2015-11-12 23:54:01]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-11-14 00:43:31]

On 2015/11/12 23:54:02, zra wrote:

Why can't both just be removed in favour of int?

[zra, 2015-11-16 18:44:30]

On 2015/11/14 00:43:31, Cutch wrote:
> On 2015/11/12 23:54:02, zra wrote:
> 
> Why can't both just be removed in favour of int?

Done. PTAL.

[Cutch, 2015-11-17 00:01:51]

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/stub.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/stub.dart:73: (endpoint.status ==
core.MojoResult.kFailedPrecondition));
Indentation on line 73

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/types.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:7: abstract class MojoResult {
Why is this marked as abstract?

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:71: abstract class MojoHandleSignals
{
ditto

[zra, 2015-11-17 14:57:29]

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/stub.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/stub.dart:73: (endpoint.status ==
core.MojoResult.kFailedPrecondition));
On 2015/11/17 00:01:51, Cutch wrote:
> Indentation on line 73

Unfortunately, this is the result of the Dart formatter.

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/types.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:7: abstract class MojoResult {
On 2015/11/17 00:01:51, Cutch wrote:
> Why is this marked as abstract?

Instantiating a MojoResult no longer makes sense. Marking the class 'abstract'
forbids instantiation.

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:71: abstract class MojoHandleSignals
{
On 2015/11/17 00:01:51, Cutch wrote:
> ditto

Same reason.

[Cutch, 2015-11-17 15:14:33]

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/types.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:7: abstract class MojoResult {
On 2015/11/17 14:57:29, zra wrote:
> On 2015/11/17 00:01:51, Cutch wrote:
> > Why is this marked as abstract?
> 
> Instantiating a MojoResult no longer makes sense. Marking the class 'abstract'
> forbids instantiation.

abstract class implies an interface with abstract methods which must be
implemented. When I read it, I searched the file for abstract methods.

To stop the class from being instantiated:

class MojoResult {
  // Private constructor.
  MojoResult._();
}

[zra, 2015-11-17 16:37:37]

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/types.dart (right):

https://codereview.chromium.org/1439993003/diff/40001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/types.dart:7: abstract class MojoResult {
On 2015/11/17 15:14:33, Cutch wrote:
> On 2015/11/17 14:57:29, zra wrote:
> > On 2015/11/17 00:01:51, Cutch wrote:
> > > Why is this marked as abstract?
> > 
> > Instantiating a MojoResult no longer makes sense. Marking the class
'abstract'
> > forbids instantiation.
> 
> abstract class implies an interface with abstract methods which must be
> implemented. When I read it, I searched the file for abstract methods.
> 
> To stop the class from being instantiated:
> 
> class MojoResult {
>   // Private constructor.
>   MojoResult._();
> }

Done.

[Cutch, 2015-11-17 16:42:55]

lgtm

[zra, 2015-11-17 17:00:27]

Committed patchset #4 (id:60001) manually as
de50f4d53f7cff0def5f4fbe8a1d0fb6f0ef39de (presubmit successful).