Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: mojo/dart/packages/mojo/lib/src/proxy.dart

Issue 1439993003: Dart: Avoid MojoResult and MojoHandleSignals constructors. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/message_pipe.dart ('k') | mojo/dart/packages/mojo/lib/src/stub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/packages/mojo/lib/src/proxy.dart
diff --git a/mojo/dart/packages/mojo/lib/src/proxy.dart b/mojo/dart/packages/mojo/lib/src/proxy.dart
index 72ef13daa575db2121467655da7eee67f0098ae2..7bf4f154d2e6054acbe220152b1ab03d7ba285e6 100644
--- a/mojo/dart/packages/mojo/lib/src/proxy.dart
+++ b/mojo/dart/packages/mojo/lib/src/proxy.dart
@@ -86,7 +86,7 @@ abstract class Proxy extends core.MojoEventHandler {
var serviceMessage = message.serializeWithHeader(header);
endpoint.write(serviceMessage.buffer, serviceMessage.buffer.lengthInBytes,
serviceMessage.handles);
- if (!endpoint.status.isOk) {
+ if (endpoint.status != core.MojoResult.kOk) {
proxyError("Write to message pipe endpoint failed.");
}
}
@@ -109,11 +109,11 @@ abstract class Proxy extends core.MojoEventHandler {
endpoint.write(serviceMessage.buffer, serviceMessage.buffer.lengthInBytes,
serviceMessage.handles);
- if (endpoint.status.isOk) {
+ if (endpoint.status == core.MojoResult.kOk) {
_completerMap[id] = completer;
_pendingCount++;
} else {
- proxyError("Write to message pipe endpoint failed.");
+ proxyError("Write to message pipe endpoint failed: ${endpoint}");
}
return completer.future;
}
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/message_pipe.dart ('k') | mojo/dart/packages/mojo/lib/src/stub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698