Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1439983002: Subzero: Add "--verbose=status" option. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add "--verbose=status" option. This just prints the function being translated, once per function. This is useful if there is a crash or fatal error somewhere, and you want to quickly discover which function to set -verbose-focus on. Also, fixes some warnings/errors in the MINIMAL build. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a522965993d0cfb4ea744be24f1da3c8127d25f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/IceCfg.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/IceCfg.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceClFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceDefs.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceInstX86BaseImpl.h View 10 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-12 17:13:53 UTC) #3
Karl
lgtm
5 years, 1 month ago (2015-11-12 17:36:24 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-11-12 18:25:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a522965993d0cfb4ea744be24f1da3c8127d25f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698