- Annotate instructions that load objects from the ObjectPool or Thread.

- Annotate instructions that load objects from the ObjectPool or Thread.
- Remove disassembly tooltips.
- Surface whether a function has an intrinsic or is recognized.
- Mark intrinsified or ffi functions in the profile.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/df64bb161928b504343eebfc6db6dd2b0986435e

[rmacnak, 2015-11-12 02:15:13]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[rmacnak, 2015-11-12 02:15:13]

Also, there's a crash if you request a profile on simmips with DeltaBlue, which
is probably related to the change removing the Instructions -> Code pointer.

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:536: if
(function.hasIntrinsic == true) {
Hit checked mode error, which suggests this sometimes runs before function has
loaded from its servicemap. Not sure how any of the attritutes successfully
display if that's the case though.

[Cutch, 2015-11-12 17:33:53]

LGTM with some nits

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:536: if
(function.hasIntrinsic == true) {
On 2015/11/12 02:15:13, rmacnak wrote:
> Hit checked mode error, which suggests this sometimes runs before function has
> loaded from its servicemap. Not sure how any of the attritutes successfully
> display if that's the case though.

Maybe rewrite to:

if ((function is ServiceFunction) && function.hasIntrinsic) {
}

https://codereview.chromium.org/1439893002/diff/40001/runtime/vm/instructions...
File runtime/vm/instructions_arm.cc (right):

https://codereview.chromium.org/1439893002/diff/40001/runtime/vm/instructions...
runtime/vm/instructions_arm.cc:183: if ((instr & 0xffff0000) == (0xe5900000 |
(PP << 16))) {
How about a kConst for these patterns?

[rmacnak, 2015-11-12 21:50:46]

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/1439893002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:536: if
(function.hasIntrinsic == true) {
On 2015/11/12 17:33:52, Cutch wrote:
> On 2015/11/12 02:15:13, rmacnak wrote:
> > Hit checked mode error, which suggests this sometimes runs before function
has
> > loaded from its servicemap. Not sure how any of the attritutes successfully
> > display if that's the case though.
> 
> Maybe rewrite to:
> 
> if ((function is ServiceFunction) && function.hasIntrinsic) {
> }

It's hasIntrinsic that's null, not function.

https://codereview.chromium.org/1439893002/diff/40001/runtime/vm/instructions...
File runtime/vm/instructions_arm.cc (right):

https://codereview.chromium.org/1439893002/diff/40001/runtime/vm/instructions...
runtime/vm/instructions_arm.cc:183: if ((instr & 0xffff0000) == (0xe5900000 |
(PP << 16))) {
On 2015/11/12 17:33:52, Cutch wrote:
> How about a kConst for these patterns?

Extracted as IsLoadWithOffset

[rmacnak, 2015-11-12 23:18:36]

Committed patchset #4 (id:60001) manually as
df64bb161928b504343eebfc6db6dd2b0986435e.