Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

Issue 1439893002: - Annotate instructions that load objects from the ObjectPool or Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/code_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/cpu_profile/cpu_profile.dart
diff --git a/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart b/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart
index c71a41ed77b47492aaec4acb0b287e8e30bbc68a..d3e0252d10cd1d23a640242f1edc3c3573940148 100644
--- a/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart
+++ b/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart
@@ -370,15 +370,22 @@ class ProfileCode {
code.profile = this;
- if (code.isDartCode) {
+ if (code.kind == CodeKind.Stub) {
+ attributes.add('stub');
+ } else if (code.kind == CodeKind.Dart) {
+ if (code.isNative) {
+ attributes.add('ffi'); // Not to be confused with a C function.
+ } else {
+ attributes.add('dart');
+ }
+ if (code.hasIntrinsic) {
+ attributes.add('intrinsic');
+ }
if (code.isOptimized) {
attributes.add('optimized');
} else {
attributes.add('unoptimized');
}
- }
- if (code.isDartCode) {
- attributes.add('dart');
} else if (code.kind == CodeKind.Tag) {
attributes.add('tag');
} else if (code.kind == CodeKind.Native) {
@@ -516,15 +523,19 @@ class ProfileFunction {
if (function.kind == FunctionKind.kTag) {
attribs.add('tag');
} else if (function.kind == FunctionKind.kStub) {
- attribs.add('dart');
attribs.add('stub');
} else if (function.kind == FunctionKind.kNative) {
attribs.add('native');
} else if (function.kind.isSynthetic()) {
attribs.add('synthetic');
+ } else if (function.isNative) {
+ attribs.add('ffi'); // Not to be confused with a C function.
} else {
attribs.add('dart');
}
+ if (function.hasIntrinsic == true) {
+ attribs.add('intrinsic');
+ }
}
ProfileFunction.fromMap(this.profile, this.function, Map data) {
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/code_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698