text-overflow on button should have effect

text-overflow on button should have effect

RenderButton is derived from RenderFlexibleBox.
In https://codereview.chromium.org/23449034 its mentioned that
text-overflow on flexbox should have no effect. But in Firefox
button text-overflow:ellipsis have a effect.
I have added a exception for Renderbutton by returning true
for canCollapseAnonymousBlockChild().

BUG=107014, 319894
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165720

[gnana, 2014-01-22 15:51:32]

Please have a look.

[cbiesinger, 2014-01-22 22:49:41]

lgtm

but, I'm not an OWNER so ojan will have to review this too.

I wish RenderButton weren't a flexbox, but we have no good way to do that today
:(

[ojan, 2014-01-22 23:16:31]

lgtm

[commit-bot: I haz the power, 2014-01-22 23:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/143983013/1

[commit-bot: I haz the power, 2014-01-22 23:17:10]

Failed to apply patch for Source/core/rendering/RenderFlexibleBox.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/RenderFlexibleBox.h
  Hunk #1 FAILED at 47.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/RenderFlexibleBox.h.rej

Patch:       Source/core/rendering/RenderFlexibleBox.h
Index: Source/core/rendering/RenderFlexibleBox.h
diff --git a/Source/core/rendering/RenderFlexibleBox.h
b/Source/core/rendering/RenderFlexibleBox.h
old mode 100644
new mode 100755
index
0dc737bee245b2db047fe5d931ab658e754cab53..b84874d74198955a1db9f4f25bf95d358448633b
--- a/Source/core/rendering/RenderFlexibleBox.h
+++ b/Source/core/rendering/RenderFlexibleBox.h
@@ -47,7 +47,7 @@ public:
 
     virtual bool isFlexibleBox() const OVERRIDE FINAL { return true; }
     virtual bool avoidsFloats() const OVERRIDE FINAL { return true; }
-    virtual bool canCollapseAnonymousBlockChild() const OVERRIDE FINAL { return
false; }
+    virtual bool canCollapseAnonymousBlockChild() const OVERRIDE { return
false; }
     virtual void layoutBlock(bool relayoutChildren, LayoutUnit
pageLogicalHeight = 0) OVERRIDE FINAL;
 
     virtual int baselinePosition(FontBaseline, bool firstLine,
LineDirectionMode, LinePositionMode = PositionOnContainingLine) const OVERRIDE;

[commit-bot: I haz the power, 2014-01-23 06:07:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/143983013/70001

[commit-bot: I haz the power, 2014-01-23 09:28:01]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[gnana, 2014-01-23 16:12:58]

Thanks ojan and cbeisinger.

The layout test case is failing for mac_snowleopard port.
Because in snow leopard different font is used and hence rendering is different.

I tried adding "font-family: Ahem", then it fails in all port. and then expected
and actual image looks corrupted.

Please suggest me how i can fix this for mac snowleoparf.

[cbiesinger, 2014-01-24 00:38:57]

On 2014/01/23 16:12:58, gnana wrote:
> Thanks ojan and cbeisinger.
> 
> The layout test case is failing for mac_snowleopard port.
> Because in snow leopard different font is used and hence rendering is
different.
> 
> I tried adding "font-family: Ahem", then it fails in all port. and then
expected
> and actual image looks corrupted.
> 
> Please suggest me how i can fix this for mac snowleoparf.

Can you explain more how font-family: Ahem failed? I would think that as long as
you put the ... in the right place that should work?

Another option is to make the button really narrow (say, 3px), so that no actual
character will be rendered, only the dots.

[ojan, 2014-01-24 00:55:50]

If you add the following styling to the button, you can just use a div + the
same lorem text in your -expected.html file instead of a button:

     -webkit-appearance: none;
     border: 2px solid;
     background-color: white;

[commit-bot: I haz the power, 2014-01-24 07:03:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/143983013/330001

[commit-bot: I haz the power, 2014-01-24 08:10:49]

Change committed as 165720