Issue 23449034: text-overflow on flexbox should have no effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23449034: text-overflow on flexbox should have no effect (Closed)

Created:
7 years, 3 months ago by cbiesinger

Modified:
7 years, 3 months ago

Reviewers:
Julien - ping for review, ojan

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

text-overflow on flexbox should have no effect Since flexbox doesn't have any direct inline children, text-overflow should have no effect. There is code that checks for the parent's text-overflow style, but that should be limited to blocks where we created anon blocks because of mixed inlines and blocks -- grid and flex should not be affected. See also this thread: http://lists.w3.org/Archives/Public/www-style/2013Sep/0070.html R=ojan@chromium.org,jchaffraix@chromium.org BUG=285943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157795

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -2 lines)			Patch
A	LayoutTests/css3/flexbox/text-overflow-on-flexbox.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	LayoutTests/css3/flexbox/text-overflow-on-flexbox-expected.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/23449034/1

7 years, 3 months ago (2013-09-14 00:29:20 UTC) #3

Message was sent while issue was closed.

Change committed as 157795