Issue 143983002: Rework end-of-value field handling in VTTRegion::parseSettingValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143983002: Rework end-of-value field handling in VTTRegion::parseSettingValue (Closed)

Created:
6 years, 11 months ago by fs

Modified:
6 years, 11 months ago

Reviewers:
Mike West, jochen (gone - plz use gerrit)

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Rework end-of-value field handling in VTTRegion::parseSettingValue Hoist the end-of-input/value check in VTTParser::parseFloatPercentageValuePair, and pass a Scanner directly to it. Open-code VTTParser::collectDigitsToInt in VTTRegion::parseSettingValue, and then remove the former. This leaves VTTLegacyScanner without any users, so remove it too. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165456

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -53 lines)			Patch
M	Source/core/html/track/vtt/VTTParser.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTParser.cpp	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTRegion.cpp	View	1 chunk	+16 lines, -6 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTScanner.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

On 2014/01/21 12:00:24, fs wrote: > Jochen, another one to defer to Mike ;-) I ...

6 years, 11 months ago (2014-01-21 12:10:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/143983002/1

6 years, 11 months ago (2014-01-21 12:38:42 UTC) #4

Message was sent while issue was closed.

Change committed as 165456

Expand Messages | Collapse Messages