Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: Source/core/html/track/vtt/VTTParser.h

Issue 143983002: Rework end-of-value field handling in VTTRegion::parseSettingValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTParser.h
diff --git a/Source/core/html/track/vtt/VTTParser.h b/Source/core/html/track/vtt/VTTParser.h
index cb2f2468f7f38930744289246ad281d814e4033a..dcd2cb79204f3742048977c1194c2caf6494d89b 100644
--- a/Source/core/html/track/vtt/VTTParser.h
+++ b/Source/core/html/track/vtt/VTTParser.h
@@ -91,12 +91,11 @@ public:
// U+0020 SPACE characters or U+0009 CHARACTER TABULATION (tab) characters.
return c == ' ' || c == '\t';
}
- static unsigned collectDigitsToInt(const String& input, unsigned* position, int& number);
static bool collectTimeStamp(const String&, double& timeStamp);
// Useful functions for parsing percentage settings.
static bool parseFloatPercentageValue(VTTScanner& valueScanner, float& percentage);
- static bool parseFloatPercentageValuePair(const String&, char, FloatPoint&);
+ static bool parseFloatPercentageValuePair(VTTScanner&, char, FloatPoint&);
// Create the DocumentFragment representation of the WebVTT cue text.
static PassRefPtr<DocumentFragment> createDocumentFragmentFromCueText(Document&, const String&);
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698