SVG: Promote d to a property

third_party/WebKit/Source/core/style/SVGComputedStyle.h

Index: third_party/WebKit/Source/core/style/SVGComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/SVGComputedStyle.h b/third_party/WebKit/Source/core/style/SVGComputedStyle.h
index f8925f1c3a6dd041bab6ccb4265330117ddca37f..348ef800df82c02d1635597b6dcac9305647b9ef 100644
--- a/third_party/WebKit/Source/core/style/SVGComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/SVGComputedStyle.h
@@ -90,6 +90,7 @@ public:
     static const AtomicString& initialMarkerEndResource() { return nullAtom; }
     static EMaskType initialMaskType() { return MT_LUMINANCE; }
     static EPaintOrder initialPaintOrder() { return PaintOrderNormal; }
+    static const SVGPathByteStream* initialD() { return nullptr; }

[fs, 2015/11/26 12:51:40]

It feels like having a "template" - empty path object here would make using code
simpler. Having an empty path should be consistent with "missing value default".
This goes together with the call for a slightly more complex representation.

[Eric Willigers, 2015/12/10 23:52:52]

I like the template empty path object, but who should own it? When we have
Oilpan, we don't want the empty path object to be garbage collected.

[fs, 2015/12/11 13:01:58]

It looks like you handled this in the way at least I would expect. More
(somewhat) related to this elsewhere though.

     static Length initialCx() { return Length(Fixed); }
     static Length initialCy() { return Length(Fixed); }
     static Length initialX() { return Length(Fixed); }
@@ -115,6 +116,15 @@ public:
     void setTextAnchor(ETextAnchor val) { svg_inherited_flags.textAnchor = val; }
     void setMaskType(EMaskType val) { svg_noninherited_flags.f.maskType = val; }
     void setPaintOrder(EPaintOrder val) { svg_inherited_flags.paintOrder = (int)val; }
+    void setD(const SVGPathByteStream* d)
+    {
+        if (d) {
+            if (!layout->d || !(*layout->d == *d))
+                layout.access()->d = d->copy();
+        } else if (layout->d) {
+            layout.access()->d->clear();
+        }
+    }
     void setCx(const Length& obj)
     {
         if (!(layout->cx == obj))
@@ -333,6 +343,7 @@ public:
     const Color& floodColor() const { return misc->floodColor; }
     const Color& lightingColor() const { return misc->lightingColor; }
     const Length& baselineShiftValue() const { return misc->baselineShiftValue; }
+    const SVGPathByteStream* d() const { return layout->d.get(); }
     const Length& cx() const { return layout->cx; }
     const Length& cy() const { return layout->cy; }
     const Length& x() const { return layout->x; }