SVG: Promote d to a property

third_party/WebKit/Source/core/style/SVGComputedStyle.h

 /*
     Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
                   2004, 2005 Rob Buis <buis@kde.org>
     Copyright (C) 2005, 2006 Apple Computer, Inc.
     Copyright (C) Research In Motion Limited 2010. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
@@ skipping 72 matching lines @@
     static Color initialFloodColor() { return Color(0, 0, 0); }
     static Color initialLightingColor() { return Color(255, 255, 255); }
     static const AtomicString& initialClipperResource() { return nullAtom; }
     static const AtomicString& initialFilterResource() { return nullAtom; }
     static const AtomicString& initialMaskerResource() { return nullAtom; }
     static const AtomicString& initialMarkerStartResource() { return nullAtom; }
     static const AtomicString& initialMarkerMidResource() { return nullAtom; }
     static const AtomicString& initialMarkerEndResource() { return nullAtom; }
     static EMaskType initialMaskType() { return MT_LUMINANCE; }
     static EPaintOrder initialPaintOrder() { return PaintOrderNormal; }
+    static const SVGPathByteStream* initialD() { return nullptr; }

[fs, 2015/11/26 12:51:40]

It feels like having a "template" - empty path object here would make using code
simpler. Having an empty path should be consistent with "missing value default".
This goes together with the call for a slightly more complex representation.

[Eric Willigers, 2015/12/10 23:52:52]

I like the template empty path object, but who should own it? When we have
Oilpan, we don't want the empty path object to be garbage collected.

[fs, 2015/12/11 13:01:58]

It looks like you handled this in the way at least I would expect. More
(somewhat) related to this elsewhere though.

     static Length initialCx() { return Length(Fixed); }
     static Length initialCy() { return Length(Fixed); }
     static Length initialX() { return Length(Fixed); }
     static Length initialY() { return Length(Fixed); }
     static Length initialR() { return Length(Fixed); }
     static Length initialRx() { return Length(Fixed); }
     static Length initialRy() { return Length(Fixed); }
 
     // SVG CSS Property setters
     void setAlignmentBaseline(EAlignmentBaseline val) { svg_noninherited_flags.f.alignmentBaseline = val; }
     void setDominantBaseline(EDominantBaseline val) { svg_inherited_flags.dominantBaseline = val; }
     void setBaselineShift(EBaselineShift val) { svg_noninherited_flags.f.baselineShift = val; }
     void setVectorEffect(EVectorEffect val) { svg_noninherited_flags.f.vectorEffect = val; }
     void setBufferedRendering(EBufferedRendering val) { svg_noninherited_flags.f.bufferedRendering = val; }
     void setCapStyle(LineCap val) { svg_inherited_flags.capStyle = val; }
     void setClipRule(WindRule val) { svg_inherited_flags.clipRule = val; }
     void setColorInterpolation(EColorInterpolation val) { svg_inherited_flags.colorInterpolation = val; }
     void setColorInterpolationFilters(EColorInterpolation val) { svg_inherited_flags.colorInterpolationFilters = val; }
     void setColorRendering(EColorRendering val) { svg_inherited_flags.colorRendering = val; }
     void setFillRule(WindRule val) { svg_inherited_flags.fillRule = val; }
     void setJoinStyle(LineJoin val) { svg_inherited_flags.joinStyle = val; }
     void setShapeRendering(EShapeRendering val) { svg_inherited_flags.shapeRendering = val; }
     void setTextAnchor(ETextAnchor val) { svg_inherited_flags.textAnchor = val; }
     void setMaskType(EMaskType val) { svg_noninherited_flags.f.maskType = val; }
     void setPaintOrder(EPaintOrder val) { svg_inherited_flags.paintOrder = (int)val; }
+    void setD(const SVGPathByteStream* d)
+    {
+        if (d) {
+            if (!layout->d || !(*layout->d == *d))
+                layout.access()->d = d->copy();
+        } else if (layout->d) {
+            layout.access()->d->clear();
+        }
+    }
     void setCx(const Length& obj)
     {
         if (!(layout->cx == obj))
             layout.access()->cx = obj;
     }
     void setCy(const Length& obj)
     {
         if (!(layout->cy == obj))
             layout.access()->cy = obj;
     }
@@ skipping 198 matching lines @@
     SVGDashArray* strokeDashArray() const { return stroke->dashArray.get(); }
     float strokeMiterLimit() const { return stroke->miterLimit; }
     const UnzoomedLength& strokeWidth() const { return stroke->width; }
     const Length& strokeDashOffset() const { return stroke->dashOffset; }
     float stopOpacity() const { return stops->opacity; }
     const Color& stopColor() const { return stops->color; }
     float floodOpacity() const { return misc->floodOpacity; }
     const Color& floodColor() const { return misc->floodColor; }
     const Color& lightingColor() const { return misc->lightingColor; }
     const Length& baselineShiftValue() const { return misc->baselineShiftValue; }
+    const SVGPathByteStream* d() const { return layout->d.get(); }
     const Length& cx() const { return layout->cx; }
     const Length& cy() const { return layout->cy; }
     const Length& x() const { return layout->x; }
     const Length& y() const { return layout->y; }
     const Length& r() const { return layout->r; }
     const Length& rx() const { return layout->rx; }
     const Length& ry() const { return layout->ry; }
     const AtomicString& clipperResource() const { return resources->clipper; }
     const AtomicString& filterResource() const { return resources->filter; }
     const AtomicString& maskerResource() const { return resources->masker; }
@@ skipping 117 matching lines @@
         svg_noninherited_flags.f.baselineShift = initialBaselineShift();
         svg_noninherited_flags.f.vectorEffect = initialVectorEffect();
         svg_noninherited_flags.f.bufferedRendering = initialBufferedRendering();
         svg_noninherited_flags.f.maskType = initialMaskType();
     }
 };
 
 } // namespace blink
 
 #endif // SVGComputedStyle_h