Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 143973006: New Sync datatype for Synced Notifications App Info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index be6394257c259167b7b037e035bb77d5af891277..2b1d83ce95ff9d3cba71bf5ca8e859caf5023d13 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -34,6 +34,7 @@
#include "sync/protocol/priority_preference_specifics.pb.h"
#include "sync/protocol/proto_enum_conversions.h"
#include "sync/protocol/search_engine_specifics.pb.h"
+#include "sync/protocol/server_app_info_specifics.pb.h"
#include "sync/protocol/session_specifics.pb.h"
#include "sync/protocol/sync.pb.h"
#include "sync/protocol/synced_notification_specifics.pb.h"
@@ -241,6 +242,17 @@ base::DictionaryValue* TimeRangeDirectiveToValue(
return value;
}
+// AppInfo conversion functions.
+base::DictionaryValue* SyncedNotificationAppInfoToValue(
+ const sync_pb::AppInfo& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_STR_REP(app_id);
+ SET_STR(settings_display_name);
+ SET(icon, SyncedNotificationImageToValue);
+ // TODO(petewil): Add fields for the monochrome icon when it is available.
+ return value;
+}
+
base::DictionaryValue* SyncedNotificationImageToValue(
const sync_pb::SyncedNotificationImage& proto) {
base::DictionaryValue* value = new base::DictionaryValue();
@@ -650,6 +662,13 @@ base::DictionaryValue* PriorityPreferenceSpecificsToValue(
return value;
}
+base::DictionaryValue* SyncedNotificationAppInfoSpecificsToValue(
+ const sync_pb::AppInfoSpecifics& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_REP(app_info, SyncedNotificationAppInfoToValue);
+ return value;
+}
+
base::DictionaryValue* SyncedNotificationSpecificsToValue(
const sync_pb::SyncedNotificationSpecifics& proto) {
// There is a lot of data, for now just use heading, description, key, and
@@ -725,6 +744,7 @@ base::DictionaryValue* EntitySpecificsToValue(
const sync_pb::EntitySpecifics& specifics) {
base::DictionaryValue* value = new base::DictionaryValue();
SET_FIELD(app, AppSpecificsToValue);
+ SET_FIELD(app_info, SyncedNotificationAppInfoSpecificsToValue);
SET_FIELD(app_list, AppListSpecificsToValue);
SET_FIELD(app_notification, AppNotificationToValue);
SET_FIELD(app_setting, AppSettingSpecificsToValue);

Powered by Google App Engine
This is Rietveld 408576698