New Sync datatype for Synced Notifications App Info

sync/protocol/server_app_info_specifics.proto

Index: sync/protocol/server_app_info_specifics.proto
diff --git a/sync/protocol/server_app_info_specifics.proto b/sync/protocol/server_app_info_specifics.proto
new file mode 100644
index 0000000000000000000000000000000000000000..4019baa28587f1280c8abbfe693f4989df335b78
--- /dev/null
+++ b/sync/protocol/server_app_info_specifics.proto
@@ -0,0 +1,33 @@
+// Copyright 2014 Google Inc. All Rights Reserved.

[Nicolas Zea, 2014/01/22 00:43:39]

this file should be app_info_specifics, not server_app_info_specifics.

[Pete Williamson, 2014/01/22 19:51:10]

Done.

+//
+// Sync protocol datatype extension for appInfo objects.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+option retain_unknown_fields = true;
+
+package sync_pb;
+
+import "synced_notification_render.proto";
+
+message AppInfoSpecifics {

[Nicolas Zea, 2014/01/22 00:43:39]

Given that the type is called SyncedNotificationAppInfo, we prefer naming to
match the type, i.e. SyncedNotificationAppInfoSpecifics.

[Pete Williamson, 2014/01/22 19:51:10]

On the server it is just called AppInfoSpecifics, I'd like to keep the name
matching the server, even though we name the client with the more specific name.

+  // Information of the list of apps we know about.
+  // NOTE: This may not be the comprehensive list of apps that send
+  // notifications. At best, it will contain all the first party apps and
+  // paging support is not needed.
+  repeated AppInfo app_info = 1;
+}
+
+message AppInfo {
+  // The application ID.
+  repeated string app_id = 1;

[Nicolas Zea, 2014/01/21 23:25:10]

Perhaps I didn't follow our discussion closely enough, but I thought we were
going to have each app be a separate specifics? Couldn't you have the app_id be
the unique id for the each item?

[Pete Williamson, 2014/01/22 19:51:10]

We chatted about this, and we agreed that we need better comments to explain
what is going on here.  New comments added.

+
+  // The name to use in the settings screen for this app.
+  optional string settings_display_name = 2;
+
+  // The icon to use. The URL of the icon may point to a
+  // hi-res image, so clients should always size the image to the
+  // preferred width and height specified in the Image proto.
+  optional SyncedNotificationImage icon = 3;
+}