Issue 1439683002: Fix line spacing for push instructions in ARM assembly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1439683002: Fix line spacing for push instructions in ARM assembly. (Closed)

Created:
5 years, 1 month ago by Karl

Modified:
5 years, 1 month ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -19 lines)			Patch
M	src/IceInstARM32.cpp	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	tests_lit/assembler/arm32/bic.ll	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	tests_lit/assembler/arm32/push-pop.ll	View	2 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Karl

5 years, 1 month ago (2015-11-11 21:34:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f2674646eaabbec45761b163f7995c151df51574 (presubmit successful).