Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 143953007: Changes look for scrollbars on windows (2) (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
Reviewers:
jam, sadrul
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Visibility:
Public.

Description

Changes look for scrollbars on windows (2) Additionally respects the size from the OS. BUG=333499 332937 TEST=none R=jam@chromium.org, sadrul@chromium.org TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246401

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -146 lines) Patch
M chrome/app/chrome_main_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/webkit_support.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
A ui/base/nine_image_painter_factory.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ui/base/nine_image_painter_factory.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 2 chunks +8 lines, -0 lines 0 comments Download
A ui/gfx/nine_image_painter.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ui/gfx/nine_image_painter.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/native_theme/native_theme.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/native_theme/native_theme_aurawin.h View 1 chunk +72 lines, -0 lines 0 comments Download
A ui/native_theme/native_theme_aurawin.cc View 1 chunk +182 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_base.h View 4 chunks +15 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_base.cc View 7 chunks +45 lines, -29 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/resources/ui_resources.grd View 2 chunks +76 lines, -10 lines 0 comments Download
M ui/ui.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/painter.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/painter.cc View 2 chunks +8 lines, -90 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
My first patch was reverted because of failing webkit test. The test was failing for ...
6 years, 11 months ago (2014-01-21 17:57:26 UTC) #1
jam
lgtm
6 years, 11 months ago (2014-01-22 16:36:55 UTC) #2
sadrul
lgtm
6 years, 11 months ago (2014-01-22 16:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/143953007/30001
6 years, 11 months ago (2014-01-22 16:48:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=193394
6 years, 11 months ago (2014-01-22 18:31:36 UTC) #5
sky
Committed patchset #2 manually as r246401 (presubmit successful).
6 years, 11 months ago (2014-01-22 20:24:06 UTC) #6
zturner
On 2014/01/22 20:24:06, sky wrote: > Committed patchset #2 manually as r246401 (presubmit successful). Is ...
6 years, 11 months ago (2014-01-24 18:07:23 UTC) #7
sky
Accordingly to Glen arrows should appear every where on windows. -Scott On Fri, Jan 24, ...
6 years, 11 months ago (2014-01-24 18:17:36 UTC) #8
Glen Murphy
6 years, 11 months ago (2014-01-27 17:57:25 UTC) #9
Message was sent while issue was closed.
Capital-W - arrows should appear on Windows, but not ChromeOS.

On 2014/01/24 18:17:36, sky wrote:
> Accordingly to Glen arrows should appear every where on windows.
> 
>   -Scott
> 
> On Fri, Jan 24, 2014 at 10:07 AM,  <mailto:zturner@chromium.org> wrote:
> > On 2014/01/22 20:24:06, sky wrote:
> >>
> >> Committed patchset #2 manually as r246401 (presubmit successful).
> >
> >
> > Is it intentional that arrows are back on Ash as well?  Shouldn't Ash
> > continue
> > to follow ChromeOS style?
> >
> > https://codereview.chromium.org/143953007/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698