Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 144173002: Hard codes ScrollbarThemeGtkOrAura::scrollbarThickness to 15 in layout test mode (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
Reviewers:
Dirk Pranke, jamesr
CC:
blink-reviews
Visibility:
Public.

Description

Hard codes ScrollbarThemeGtkOrAura::scrollbarThickness to 15 in layout test mode As part of 333499 the width of scrollbars under windows is going to honor what the OS says (as it was before aura). For tests the size needs to be hardcoded (we had been doing this in ScrollbarThemeWin.cpp). BUG=333499 332937 TEST=none R=dpranke@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165497

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : early out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sky
6 years, 11 months ago (2014-01-21 17:53:56 UTC) #1
Dirk Pranke
lgtm
6 years, 11 months ago (2014-01-21 18:51:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/144173002/40001
6 years, 11 months ago (2014-01-21 18:52:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=14386
6 years, 11 months ago (2014-01-21 19:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/144173002/40001
6 years, 11 months ago (2014-01-21 20:24:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=14402
6 years, 11 months ago (2014-01-21 20:44:20 UTC) #6
sky
+jamesr as Dirk isn't an OWNER here.
6 years, 11 months ago (2014-01-21 20:45:46 UTC) #7
jamesr
lgtm
6 years, 11 months ago (2014-01-21 20:46:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/144173002/40001
6 years, 11 months ago (2014-01-21 20:48:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
6 years, 11 months ago (2014-01-21 21:19:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/144173002/280001
6 years, 11 months ago (2014-01-21 21:40:37 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18392
6 years, 11 months ago (2014-01-21 22:12:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/144173002/280001
6 years, 11 months ago (2014-01-21 23:21:37 UTC) #13
sky
6 years, 11 months ago (2014-01-22 00:59:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 manually as r165497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698