Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/perf/benchmarks/dummy_benchmark.py

Issue 1439453002: [tools/perf] Add a broken page to dummy_benchmark.noisy_benchmark_1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/dummy_story_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/dummy_benchmark.py
diff --git a/tools/perf/benchmarks/dummy_benchmark.py b/tools/perf/benchmarks/dummy_benchmark.py
index 2011be2fb6e40633c7b0ee3e5c8bb6c6161ed98b..b182881f35e4d0996cf74446f1ae9cb474859b67 100644
--- a/tools/perf/benchmarks/dummy_benchmark.py
+++ b/tools/perf/benchmarks/dummy_benchmark.py
@@ -14,7 +14,7 @@ from core import perf_benchmark
from telemetry.value import scalar
from telemetry.page import page_test
-import page_sets
+from page_sets import dummy_story_set
class _DummyTest(page_test.PageTest):
@@ -33,7 +33,7 @@ class _DummyTest(page_test.PageTest):
class _DummyBenchmark(perf_benchmark.PerfBenchmark):
- page_set = page_sets.DummyStorySet
+ page_set = dummy_story_set.DummyStorySet
class DummyBenchmarkOne(_DummyBenchmark):
@@ -56,3 +56,9 @@ class DummyBenchmarkTwo(_DummyBenchmark):
@classmethod
def Name(cls):
return 'dummy_benchmark.noisy_benchmark_1'
+
+ def CreateStorySet(self, options):
+ del options # unused
+ story_set = dummy_story_set.DummyStorySet()
+ story_set.AddStory(dummy_story_set.BrokenDummyPage(story_set))
+ return story_set
« no previous file with comments | « no previous file | tools/perf/page_sets/dummy_story_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698