Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/perf/page_sets/dummy_story_set.py

Issue 1439453002: [tools/perf] Add a broken page to dummy_benchmark.noisy_benchmark_1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/dummy_benchmark.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/dummy_story_set.py
diff --git a/tools/perf/page_sets/dummy_story_set.py b/tools/perf/page_sets/dummy_story_set.py
index 5575468fd59874b0e693f0211aefa58e80e5d7a4..b594f2616731f8a2ddc1a993de37e9c17ee83b39 100644
--- a/tools/perf/page_sets/dummy_story_set.py
+++ b/tools/perf/page_sets/dummy_story_set.py
@@ -12,10 +12,23 @@ class DummyPage(page_module.Page):
url='file://dummy_page.html',
page_set=page_set)
- def PerformPageInteractions(self, action_runner):
+ def RunPageInteractions(self, action_runner):
assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 2
+class BrokenDummyPage(page_module.Page):
+
+ def __init__(self, page_set):
+ super(BrokenDummyPage, self).__init__(
+ url='file://dummy_page.html',
+ name='Broken dummy page',
+ page_set=page_set)
+
+ def RunPageInteractions(self, action_runner):
+ # The call below should raise an AssertionError
+ assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 3
+
+
class DummyStorySet(story.StorySet):
def __init__(self):
« no previous file with comments | « tools/perf/benchmarks/dummy_benchmark.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698