Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1439453002: [tools/perf] Add a broken page to dummy_benchmark.noisy_benchmark_1 (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
4 years, 10 months ago
Reviewers:
prasadv
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Add a broken page to dummy_benchmark.noisy_benchmark_1 *PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1 for intergration testing purpose. Please coordinate with prasadv@ before your revert this. BUG=537676, 581465 Committed: https://crrev.com/4267f6b7365384e9eb57c0a837f9a4efacaf221e Cr-Commit-Position: refs/heads/master@{#371640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M tools/perf/benchmarks/dummy_benchmark.py View 3 chunks +8 lines, -2 lines 0 comments Download
M tools/perf/page_sets/dummy_story_set.py View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
nednguyen
5 years, 1 month ago (2015-11-10 21:47:33 UTC) #2
prasadv
lgtm
4 years, 10 months ago (2016-01-26 22:30:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439453002/1
4 years, 10 months ago (2016-01-26 22:33:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/5815)
4 years, 10 months ago (2016-01-26 23:11:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439453002/1
4 years, 10 months ago (2016-01-26 23:15:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 23:56:39 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 23:58:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4267f6b7365384e9eb57c0a837f9a4efacaf221e
Cr-Commit-Position: refs/heads/master@{#371640}

Powered by Google App Engine
This is Rietveld 408576698