extensions/browser/api/serial/serial_connection.cc - Issue 1439443002: Reland: Add code to deal with serial device disconnection detection on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_connection.cc

Issue 1439443002: Reland: Add code to deal with serial device disconnection detection on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated code to call thread helper from UI thread Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/serial/serial_connection.cc

diff --git a/extensions/browser/api/serial/serial_connection.cc b/extensions/browser/api/serial/serial_connection.cc

index edf6a0dce077fd92d7a537a3d631cecd4f6a93c5..178bfe7a8d69890ebe598bee4f1d03600541d985 100644

--- a/extensions/browser/api/serial/serial_connection.cc

+++ b/extensions/browser/api/serial/serial_connection.cc

@@ -169,6 +169,7 @@ SerialConnection::SerialConnection(const std::string& port,

content::BrowserThread::GetMessageLoopProxyForThread(

content::BrowserThread::UI))) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

+ io_handler_->set_port(port);

Reilly Grant (use Gerrit) 2015/11/11 20:43:59 Why not set port_ in Open?

juncai 2015/11/12 05:27:08 Done.

}

SerialConnection::~SerialConnection() {

« device/serial/serial_io_handler_win.cc ('K') | « device/serial/serial_io_handler_win.cc ('k') | no next file » | no next file with comments »