Chromium Code Reviews Chromium Code Reviews
Issue 1439333002:
Service Worker: Add Clients.get(id) (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..27aa8f447887b5f07049fb273691d3be3f29078b |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| @@ -0,0 +1,70 @@ |
| +<!DOCTYPE html> |
| +<title>Service Worker: Clients.get</title> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="../resources/get-host-info.js"></script> |
| +<script src="resources/test-helpers.js"></script> |
| +<script> |
| +var host_info = get_host_info(); |
|
nhiroki
2016/02/08 06:27:02
never used?
jungkees
2016/02/12 15:03:22
Removed it.
|
| + |
| +var scope = 'resources/clients-get-frame.html'; |
| +var t = async_test('Test Clients.get()'); |
| +var clientIds = []; |
| +var frame; |
| +t.step(function() { |
| + service_worker_unregister_and_register( |
| + t, 'resources/clients-get-worker.js', scope) |
| + .then(function(registration) { |
|
nhiroki
2016/02/08 06:27:02
Can you register "registration.unregister()" with
jungkees
2016/02/12 15:03:21
Done.
|
| + return wait_for_state(t, registration.installing, 'activated'); |
| + }) |
| + .then(function() { |
| + return with_iframe(scope + '#1'); |
| + }) |
| + .then(function(frame1) { |
|
nhiroki
2016/02/08 06:27:02
ditto: add_completion_callback(function() { frame1
jungkees
2016/02/12 15:03:21
Done.
|
| + frame1.focus(); |
| + return wait_for_clientId(); |
| + }) |
| + .then(function(clientId) { |
| + clientIds.push(clientId); |
| + return with_iframe(scope + '#2'); |
| + }) |
| + .then(function(frame2) { |
| + frame = frame2; |
|
nhiroki
2016/02/08 06:27:03
ditto: add_completion_callback(function() { frame2
jungkees
2016/02/12 15:03:21
Done.
|
| + return wait_for_clientId(); |
| + }) |
| + .then(function(clientId) { |
| + clientIds.push(clientId); |
|
nhiroki
2016/02/08 06:27:03
Can you add 'invalid-id' into |clientIds| here? Li
jungkees
2016/02/12 15:03:21
Done.
|
| + var channel = new MessageChannel(); |
| + channel.port1.onmessage = t.step_func(on_message); |
| + frame.contentWindow.navigator.serviceWorker.controller.postMessage( |
| + {port:channel.port2, clientIds:clientIds, |
| + message: 'get_client_ids'}, [channel.port2]); |
| + }) |
| + .catch(unreached_rejection(t)); |
| + }); |
| + |
| +function wait_for_clientId() { |
| + return new Promise(function(resolve, reject) { |
| + function get_client_id(e) { |
| + window.removeEventListener("message", get_client_id); |
|
nhiroki
2016/02/08 06:27:03
Can you use '' instead of ""?
"Use single quotes
jungkees
2016/02/12 15:03:21
Done.
|
| + resolve(e.data.clientId); |
| + } |
| + window.addEventListener("message", get_client_id, false); |
|
nhiroki
2016/02/08 06:27:02
ditto.
jungkees
2016/02/12 15:03:22
Done.
|
| + }); |
| +} |
| + |
| +var expected = [ |
| + /* visibilityState, focused, url, frameType */ |
| + ['visible', true, new URL(scope + '#1', location).toString(), 'nested'], |
| + ['visible', false, new URL(scope + '#2', location).toString(), 'nested'], |
| + undefined |
| +]; |
| + |
| +function on_message(e) { |
| + assert_equals(e.data.length, 3); |
| + assert_array_equals(e.data[0], expected[0]); |
| + assert_array_equals(e.data[1], expected[1]); |
| + assert_equals(e.data[2], expected[2]); |
| + service_worker_unregister_and_done(t, scope); |
| +} |
| +</script> |
