Chromium Code Reviews Chromium Code Reviews
Issue 1439333002:
Service Worker: Add Clients.get(id) (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <title>Service Worker: Clients.get</title> | |
| 3 <script src="../resources/testharness.js"></script> | |
| 4 <script src="../resources/testharnessreport.js"></script> | |
| 5 <script src="../resources/get-host-info.js"></script> | |
| 6 <script src="resources/test-helpers.js"></script> | |
| 7 <script> | |
| 8 var host_info = get_host_info(); | |
|
nhiroki
2016/02/08 06:27:02
never used?
jungkees
2016/02/12 15:03:22
Removed it.
| |
| 9 | |
| 10 var scope = 'resources/clients-get-frame.html'; | |
| 11 var t = async_test('Test Clients.get()'); | |
| 12 var clientIds = []; | |
| 13 var frame; | |
| 14 t.step(function() { | |
| 15 service_worker_unregister_and_register( | |
| 16 t, 'resources/clients-get-worker.js', scope) | |
| 17 .then(function(registration) { | |
|
nhiroki
2016/02/08 06:27:02
Can you register "registration.unregister()" with
jungkees
2016/02/12 15:03:21
Done.
| |
| 18 return wait_for_state(t, registration.installing, 'activated'); | |
| 19 }) | |
| 20 .then(function() { | |
| 21 return with_iframe(scope + '#1'); | |
| 22 }) | |
| 23 .then(function(frame1) { | |
|
nhiroki
2016/02/08 06:27:02
ditto: add_completion_callback(function() { frame1
jungkees
2016/02/12 15:03:21
Done.
| |
| 24 frame1.focus(); | |
| 25 return wait_for_clientId(); | |
| 26 }) | |
| 27 .then(function(clientId) { | |
| 28 clientIds.push(clientId); | |
| 29 return with_iframe(scope + '#2'); | |
| 30 }) | |
| 31 .then(function(frame2) { | |
| 32 frame = frame2; | |
|
nhiroki
2016/02/08 06:27:03
ditto: add_completion_callback(function() { frame2
jungkees
2016/02/12 15:03:21
Done.
| |
| 33 return wait_for_clientId(); | |
| 34 }) | |
| 35 .then(function(clientId) { | |
| 36 clientIds.push(clientId); | |
|
nhiroki
2016/02/08 06:27:03
Can you add 'invalid-id' into |clientIds| here? Li
jungkees
2016/02/12 15:03:21
Done.
| |
| 37 var channel = new MessageChannel(); | |
| 38 channel.port1.onmessage = t.step_func(on_message); | |
| 39 frame.contentWindow.navigator.serviceWorker.controller.postMessage( | |
| 40 {port:channel.port2, clientIds:clientIds, | |
| 41 message: 'get_client_ids'}, [channel.port2]); | |
| 42 }) | |
| 43 .catch(unreached_rejection(t)); | |
| 44 }); | |
| 45 | |
| 46 function wait_for_clientId() { | |
| 47 return new Promise(function(resolve, reject) { | |
| 48 function get_client_id(e) { | |
| 49 window.removeEventListener("message", get_client_id); | |
|
nhiroki
2016/02/08 06:27:03
Can you use '' instead of ""?
"Use single quotes
jungkees
2016/02/12 15:03:21
Done.
| |
| 50 resolve(e.data.clientId); | |
| 51 } | |
| 52 window.addEventListener("message", get_client_id, false); | |
|
nhiroki
2016/02/08 06:27:02
ditto.
jungkees
2016/02/12 15:03:22
Done.
| |
| 53 }); | |
| 54 } | |
| 55 | |
| 56 var expected = [ | |
| 57 /* visibilityState, focused, url, frameType */ | |
| 58 ['visible', true, new URL(scope + '#1', location).toString(), 'nested'], | |
| 59 ['visible', false, new URL(scope + '#2', location).toString(), 'nested'], | |
| 60 undefined | |
| 61 ]; | |
| 62 | |
| 63 function on_message(e) { | |
| 64 assert_equals(e.data.length, 3); | |
| 65 assert_array_equals(e.data[0], expected[0]); | |
| 66 assert_array_equals(e.data[1], expected[1]); | |
| 67 assert_equals(e.data[2], expected[2]); | |
| 68 service_worker_unregister_and_done(t, scope); | |
| 69 } | |
| 70 </script> | |
| OLD | NEW |
