Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/Clients.idl

Issue 1439333002: Service Worker: Add Clients.get(id) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use HTTP origins instead of HTTPS origins for layout tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/Clients.idl
diff --git a/third_party/WebKit/Source/modules/serviceworkers/Clients.idl b/third_party/WebKit/Source/modules/serviceworkers/Clients.idl
index d15694ba2ac9255df3434704e81a9980dc54c7f4..cb632216015687c1f458494b6cc1146e9e3f7513 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/Clients.idl
+++ b/third_party/WebKit/Source/modules/serviceworkers/Clients.idl
@@ -8,6 +8,7 @@
GarbageCollected,
ImplementedAs=ServiceWorkerClients,
] interface Clients {
+ [CallWith=ScriptState] Promise<any> get(DOMString id);
nhiroki 2016/02/03 09:40:00 Can you disable this using the runtime flag until
jungkees 2016/02/03 14:15:07 I added ServiceWorkerClientsGetID flag. As the int
nhiroki 2016/02/08 06:27:02 Thank you for adding it. 'stable' should be ok, bu
jungkees 2016/02/12 15:03:21 Agreed. Addressed.
[CallWith=ScriptState] Promise<sequence<Client>> matchAll(optional ClientQueryOptions options);
[RuntimeEnabled=ServiceWorkerClientAttributes, CallWith=ScriptState] Promise<WindowClient?> openWindow(USVString url);
[CallWith=ScriptState] Promise<void> claim();

Powered by Google App Engine
This is Rietveld 408576698