Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3684)

Unified Diff: chrome/browser/task_management/providers/task.h

Issue 1439213004: Fix various TaskManager bugs and add new enhancements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: V8 memory calculations are ignored for child procs that don't use it. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/task.h
diff --git a/chrome/browser/task_management/providers/task.h b/chrome/browser/task_management/providers/task.h
index 5fa551f56326e2d28435cc89b9b88cc93b48dff1..04732995e618d37f64f4fd3ab5f01a6bfa2fe134 100644
--- a/chrome/browser/task_management/providers/task.h
+++ b/chrome/browser/task_management/providers/task.h
@@ -12,6 +12,8 @@
#include "third_party/WebKit/public/web/WebCache.h"
#include "ui/gfx/image/image_skia.h"
+class Profile;
+
namespace task_management {
// Defines a task that corresponds to a tab, an app, an extension, ... etc. It
@@ -43,6 +45,9 @@ class Task {
base::ProcessHandle handle);
virtual ~Task();
+ // Gets the name of the given |profile| from the ProfileInfoCache.
+ static base::string16 GetProfileNameFromProfile(Profile* profile);
afakhry 2015/11/19 01:12:01 I'm keeping this here. It can be useful for future
ncarter (slow) 2015/11/20 21:44:37 I agree.
+
// Activates this TaskManager's task by bringing its container to the front
// (if possible).
virtual void Activate();
@@ -69,8 +74,7 @@ class Task {
// value is whatever unique IDs of their hosts in the browser process.
virtual int GetChildProcessUniqueID() const = 0;
- // The name of the profile associated with the browser context of the render
- // view host that this task represents (if this task represents a renderer).
+ // The name of the profile owning this task.
virtual base::string16 GetProfileName() const;
// Getting the Sqlite used memory (in bytes). Not all tasks reports Sqlite

Powered by Google App Engine
This is Rietveld 408576698