Fix various TaskManager bugs and add new enhancements

chrome/browser/task_management/providers/task.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_
 #define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_
 
 #include "base/basictypes.h"
 #include "base/process/process_handle.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "third_party/WebKit/public/web/WebCache.h"
 #include "ui/gfx/image/image_skia.h"
 
+class Profile;
+
 namespace task_management {
 
 // Defines a task that corresponds to a tab, an app, an extension, ... etc. It
 // represents one row in the task manager table. Multiple tasks can share the
 // same process, in which case they're grouped together in the task manager
 // table. See |task_management::TaskGroup| which represents a process possibly
 // shared by multiple tasks.
 class Task {
  public:
   enum Type {
@@ skipping 11 matching lines @@
     GPU,            /* A graphics process. */
   };
 
   // Create a task with the given |title| and the given favicon |icon|. This
   // task runs on a process whose handle is |handle|.
   Task(const base::string16& title,
        const gfx::ImageSkia* icon,
        base::ProcessHandle handle);
   virtual ~Task();
 
+  // Gets the name of the given |profile| from the ProfileInfoCache.
+  static base::string16 GetProfileNameFromProfile(Profile* profile);

[afakhry, 2015/11/19 01:12:01]

I'm keeping this here. It can be useful for future use.

[ncarter (slow), 2015/11/20 21:44:37]

I agree.

+
   // Activates this TaskManager's task by bringing its container to the front
   // (if possible).
   virtual void Activate();
 
   // Will be called to let the task refresh itself between refresh cycles.
   // |update_interval| is the time since the last task manager refresh.
   // the |refresh_flags| indicate which resources should be calculated on each
   // refresh.
   virtual void Refresh(const base::TimeDelta& update_interval,
                        int64 refresh_flags);
 
   // Will receive this notification through the task manager from
   // |ChromeNetworkDelegate::OnNetworkBytesReceived()|. The task will add to the
   // |current_byte_count_| in this refresh cycle.
   void OnNetworkBytesRead(int64 bytes_read);
 
   // Returns the task type.
   virtual Type GetType() const = 0;
 
   // This is the unique ID of the BrowserChildProcessHost/RenderProcessHost. It
   // is not the PID nor the handle of the process.
   // For a task that represents the browser process, the return value is 0. For
   // other tasks that represent renderers and other child processes, the return
   // value is whatever unique IDs of their hosts in the browser process.
   virtual int GetChildProcessUniqueID() const = 0;
 
-  // The name of the profile associated with the browser context of the render
-  // view host that this task represents (if this task represents a renderer).
+  // The name of the profile owning this task.
   virtual base::string16 GetProfileName() const;
 
   // Getting the Sqlite used memory (in bytes). Not all tasks reports Sqlite
   // memory, in this case a default invalid value of -1 will be returned.
   // Check for whether the task reports it or not first.
   bool ReportsSqliteMemory() const;
   virtual int64 GetSqliteMemoryUsed() const;
 
   // Getting the allocated and used V8 memory (in bytes). Not all tasks reports
   // V8 memory, in this case a default invalid value of -1 will be returned.
@@ skipping 45 matching lines @@
 
   // The PID of the process on which this task is running.
   const base::ProcessId process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(Task);
 };
 
 }  // namespace task_management
 
 #endif  // CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_