Support passing files/directories to git cl format

Support passing files/directories to git cl format

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247723

[enne (OOO), 2014-01-23 20:01:24]

iannucci: ping?

[iannucci, 2014-01-29 06:06:03]

lgtm, sorry for the delay, I'm international this week

https://codereview.chromium.org/143903006/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/143903006/diff/40001/git_cl.py#newcode2353
git_cl.py:2353: diff_cmd += [os.path.join(arg, '*' + ext) for ext in CLANG_EXTS]
Is clang format interpreting these globs? Because we don't seem to be running
the command with a shell (unless RunCommand does that by default :(). It may
make sense to use the glob python module here to only pass fully-expanded stuff
on the command line, but if clang-format is expanding these then that's fine too
(if we're relying on the shell to do it, then that's less fine :)).

[enne (OOO), 2014-01-29 18:18:31]

https://codereview.chromium.org/143903006/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/143903006/diff/40001/git_cl.py#newcode2353
git_cl.py:2353: diff_cmd += [os.path.join(arg, '*' + ext) for ext in CLANG_EXTS]
On 2014/01/29 06:06:03, iannucci wrote:
> Is clang format interpreting these globs? Because we don't seem to be running
> the command with a shell (unless RunCommand does that by default :(). It may
> make sense to use the glob python module here to only pass fully-expanded
stuff
> on the command line, but if clang-format is expanding these then that's fine
too
> (if we're relying on the shell to do it, then that's less fine :)).

According to
https://www.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_pathspec,
"Paths relative to the directory prefix will be matched against that pattern
using fnmatch(3); in particular, * and ? can match directory separators."

So, I think git is the one interpreting these globs and not the shell or
clang-format.

[commit-bot: I haz the power, 2014-01-29 18:19:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/143903006/40001

[iannucci, 2014-01-29 18:20:17]

On 2014/01/29 18:18:31, enne wrote:
> https://codereview.chromium.org/143903006/diff/40001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/143903006/diff/40001/git_cl.py#newcode2353
> git_cl.py:2353: diff_cmd += [os.path.join(arg, '*' + ext) for ext in
CLANG_EXTS]
> On 2014/01/29 06:06:03, iannucci wrote:
> > Is clang format interpreting these globs? Because we don't seem to be
running
> > the command with a shell (unless RunCommand does that by default :(). It may
> > make sense to use the glob python module here to only pass fully-expanded
> stuff
> > on the command line, but if clang-format is expanding these then that's fine
> too
> > (if we're relying on the shell to do it, then that's less fine :)).
> 
> According to
>
https://www.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_pathspec,
> "Paths relative to the directory prefix will be matched against that pattern
> using fnmatch(3); in particular, * and ? can match directory separators."
> 
> So, I think git is the one interpreting these globs and not the shell or
> clang-format.

Oh hey, derp. Yeah I see this is args for git-diff now. LGTM

[commit-bot: I haz the power, 2014-01-29 18:21:42]

Change committed as 247723