presubmit_canned_checks.py - Issue 143903006: Support passing files/directories to git cl format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 143903006: Support passing files/directories to git cl format (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Change canned check to only check directory Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index d52ad9582df3a2c2e81809054a903f0754694ca6..bc8c3934d6a6630e30587d71098eba8b2f54c497 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -1045,8 +1045,8 @@ def PanProjectChecks(input_api, output_api,

def CheckPatchFormatted(input_api, output_api):

import git_cl

- code, _ = git_cl.RunGitWithCode(['cl', 'format', '--dry-run'],

- suppress_stderr=True)

+ cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]

+ code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)

if code == 2:

return [output_api.PresubmitPromptWarning(

'Your patch is not formatted, please run git cl format.')]

« git_cl.py ('K') | « git_cl.py ('k') | no next file » | no next file with comments »