Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: tools/roll_deps.py

Issue 143903005: Add reviewers to roll_deps.py, remove linux_heapcheck bot (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/roll_deps.py
diff --git a/tools/roll_deps.py b/tools/roll_deps.py
index 10822f4d4c754ecb922799df420baa120ca11242..b34baac41837f0da8f61b3e656e80a773a2bd2f8 100755
--- a/tools/roll_deps.py
+++ b/tools/roll_deps.py
@@ -64,6 +64,15 @@ class DepsRollConfig(object):
self.cl_bot_list = [bot for bot in options.bots.split(',') if bot]
self.skia_git_checkout_path = options.skia_git_path
self.default_branch_name = 'autogenerated_deps_roll_branch'
+ self.reviewers_list = ','.join([
+ # 'rmistry@google.com',
+ # 'reed@google.com',
+ # 'bsalomon@google.com',
+ # 'robertphillips@google.com',
+ ])
robertphillips 2014/01/21 20:18:55 Is this going to mess up the chromium-reviews@chro
+ self.cc_list = ','.join([
+ # 'skia-team@google.com',
+ ])
@staticmethod
def GetOptionParser():
@@ -85,7 +94,6 @@ class DepsRollConfig(object):
'linux_chromeos',
'linux_chromeos_asan',
'linux_gpu',
- 'linux_heapcheck',
'linux_layout',
'linux_layout_rel',
'mac',
@@ -604,8 +612,13 @@ class GitBranchCLUpload(object):
vsp.check_call([git, 'add', filename])
vsp.check_call([git, 'commit', '-q', '-m', self._message])
- git_cl = [git, 'cl', 'upload', '-f', '--cc=skia-team@google.com',
+ git_cl = [git, 'cl', 'upload', '-f',
'--bypass-hooks', '--bypass-watchlists']
+ if self._config.cc_list:
+ git_cl.append('--cc=%s' % self._config.cc_list)
+ if self._config.reviewers_list:
+ git_cl.append('--reviewers=%s' % self._config.reviewers_list)
+
git_try = [git, 'cl', 'try', '--revision', svn_info]
git_try.extend([arg for bot in self._config.cl_bot_list
for arg in ('-b', bot)])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698