Add reviewers to roll_deps.py, remove linux_heapcheck bot

tools/roll_deps.py

 #!/usr/bin/python2
 
 # Copyright 2014 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Skia's Chromium DEPS roll script.
 
 This script:
@@ skipping 46 matching lines @@
         self.vsp = VerboseSubprocess(self.verbose)
         self.save_branches = not options.delete_branches
         self.search_depth = options.search_depth
         self.chromium_path = options.chromium_path
         self.git = options.git_path
         self.skip_cl_upload = options.skip_cl_upload
         # Split and remove empty strigns from the bot list.
         self.cl_bot_list = [bot for bot in options.bots.split(',') if bot]
         self.skia_git_checkout_path = options.skia_git_path
         self.default_branch_name = 'autogenerated_deps_roll_branch'
+        self.reviewers_list = ','.join([
+            # 'rmistry@google.com',
+            # 'reed@google.com',
+            # 'bsalomon@google.com',
+            # 'robertphillips@google.com',
+            ])

[robertphillips, 2014/01/21 20:18:55]

Is this going to mess up the chromium-reviews@chromium.org cc?

+        self.cc_list =  ','.join([
+            # 'skia-team@google.com',
+            ])
 
     @staticmethod
     def GetOptionParser():
         # pylint: disable=I0011,C0103
         """Returns an optparse.OptionParser object.
 
         Returns:
             An optparse.OptionParser object.
 
         Called by the main() function.
         """
         default_bots_list = [
             'android_clang_dbg',
             'android_dbg',
             'android_rel',
             'cros_daisy',
             'linux',
             'linux_asan',
             'linux_chromeos',
             'linux_chromeos_asan',
             'linux_gpu',
-            'linux_heapcheck',
             'linux_layout',
             'linux_layout_rel',
             'mac',
             'mac_asan',
             'mac_gpu',
             'mac_layout',
             'mac_layout_rel',
             'win',
             'win_gpu',
             'win_layout',
@@ skipping 498 matching lines @@
         # pylint: disable=I0011,R0912
         git = self._config.git
         vsp = self._config.vsp
         svn_info = str(get_svn_revision(self._config, 'HEAD'))
 
         for filename in self._file_list:
             assert os.path.exists(filename)
             vsp.check_call([git, 'add', filename])
         vsp.check_call([git, 'commit', '-q', '-m', self._message])
 
-        git_cl = [git, 'cl', 'upload', '-f', '--cc=skia-team@google.com',
+        git_cl = [git, 'cl', 'upload', '-f',
                   '--bypass-hooks', '--bypass-watchlists']
+        if self._config.cc_list:
+            git_cl.append('--cc=%s' % self._config.cc_list)
+        if self._config.reviewers_list:
+            git_cl.append('--reviewers=%s' % self._config.reviewers_list)
+
         git_try = [git, 'cl', 'try', '--revision', svn_info]
         git_try.extend([arg for bot in self._config.cl_bot_list
                         for arg in ('-b', bot)])
 
         if self._config.skip_cl_upload:
             print 'You should call:'
             print '    cd %s' % os.getcwd()
             VerboseSubprocess.print_subprocess_args(
                 '    ', [git, 'checkout', self._branch_name])
             VerboseSubprocess.print_subprocess_args('    ', git_cl)
@@ skipping 182 matching lines @@
     if not test_git_executable(options.git_path):
         option_parser.error('Invalid git executable.')
 
     config = DepsRollConfig(options)
     find_hash_and_roll_deps(config, options.revision, options.git_hash)
 
 
 if __name__ == '__main__':
     main(sys.argv[1:])