Issue 143903005: Add reviewers to roll_deps.py, remove linux_heapcheck bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143903005: Add reviewers to roll_deps.py, remove linux_heapcheck bot (Closed)

Created:
6 years, 11 months ago by hal.canary

Modified:
6 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add reviewers to roll_deps.py, remove linux_heapcheck bot The --reviewers and --cc are disabled for now, while we work on the workflow. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13137

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	tools/roll_deps.py	View		3 chunks	+15 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/143903005/diff/1/tools/roll_deps.py File tools/roll_deps.py (right): https://codereview.chromium.org/143903005/diff/1/tools/roll_deps.py#newcode72 tools/roll_deps.py:72: ]) Is this going to mess up the ...

6 years, 11 months ago (2014-01-21 20:18:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/143903005/1

6 years, 11 months ago (2014-01-21 21:29:46 UTC) #3

Message was sent while issue was closed.

Change committed as 13137

Expand Messages | Collapse Messages