Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 143893016: Fix cctest/test-types.cc to gcc 4.7's name lookup changes. (Closed)

Created:
6 years, 11 months ago by kilvadyb
Modified:
6 years, 11 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

Fix cctest/test-types.cc to gcc 4.7's name lookup changes. In GCC 4.7 the name lookup method is changed: "The C++ compiler no longer performs some extra unqualified lookups it had performed in the past, namely dependent base class scope lookups and unqualified template function lookups." BUG= TEST=cctest/test-types

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M test/cctest/test-types.cc View 17 chunks +79 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
We got the following compilation errors using gcc 4.7: ../test/cctest/test-types.cc: In instantiation of 'void Tests<Type, ...
6 years, 11 months ago (2014-01-22 13:23:18 UTC) #1
kisg
LGTM, but we need additional approval for this. Jakob, Benedikt: Could you please take a ...
6 years, 11 months ago (2014-01-22 13:54:39 UTC) #2
danno
lgtm
6 years, 11 months ago (2014-01-22 15:37:49 UTC) #3
Paul Lind
6 years, 11 months ago (2014-01-22 17:50:12 UTC) #4
This fix is now a duplicate of https://codereview.chromium.org/134643025, which
landed as 18756. So this can be closed.

Powered by Google App Engine
This is Rietveld 408576698