Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1438903002:
p1 mus+ash chrome renders ui and content (Closed)
Descriptionp1 mus+ash chrome renders ui and content
This patch forces mus+ash Chrome to software composite the ui and content
region into a single bitmap that is uploaded to the mus window server. The
approach here is similar to how Chrome paints to X11 when hardware acceleration
is not available.
BUG=554699
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c
Cr-Commit-Position: refs/heads/master@{#360289}
Committed: https://crrev.com/c109de6120382395cafa9de062710e0f9eed861a
Cr-Commit-Position: refs/heads/master@{#360464}
Patch Set 1 #Patch Set 2 : cleaned up #
Total comments: 15
Patch Set 3 : review comments #
Total comments: 2
Patch Set 4 : more review #
Total comments: 10
Patch Set 5 : review comments #
Total comments: 6
Patch Set 6 : rebase, nits #Patch Set 7 : fix build issues #Patch Set 8 : rebased #Patch Set 9 : rebase, build fix #Patch Set 10 : rebased, fixed release build #
Messages
Total messages: 62 (27 generated)
Description was changed from ========== [wip] p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. This patch is WIP and is not yet ready for review. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== [wip] p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. This patch is WIP and is not yet ready for review. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
rjkroege@chromium.org changed reviewers: + sky@chromium.org
Description was changed from ========== [wip] p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. This patch is WIP and is not yet ready for review. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
+danakj@chromium.org for content/browser/compositor +jam@chromium.org for base/threading per discussion On 2015/11/13 01:45:55, rjkroege wrote: > Description was changed from > > ========== > [wip] p1 mus+ash chrome renders ui and content > > This patch forces mus+ash Chrome to software composite the ui and content > region into a single bitmap that is uploaded to the mus window server. The > approach here is similar to how Chrome paints to X11 when hardware acceleration > is not available. > > This patch is WIP and is not yet ready for review. > > BUG=554699 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > ========== > > to > > ========== > p1 mus+ash chrome renders ui and content > > This patch forces mus+ash Chrome to software composite the ui and content > region into a single bitmap that is uploaded to the mus window server. The > approach here is similar to how Chrome paints to X11 when hardware acceleration > is not available. > > BUG=554699 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > ==========
rjkroege@chromium.org changed reviewers: + danakj@chromium.org, jam@chromium.org
danakj@chromium.org: Please review changes in jam@chromium.org: Please review changes in
fsamuel@chromium.org changed reviewers: + fsamuel@chromium.org
A few comments, thoughts and nits. https://codereview.chromium.org/1438903002/diff/20001/components/bitmap_uploa... File components/bitmap_uploader/bitmap_uploader.h (right): https://codereview.chromium.org/1438903002/diff/20001/components/bitmap_uploa... components/bitmap_uploader/bitmap_uploader.h:23: extern const char kBitmapUploaderForAcceleratedWidget[]; This constant doesn't feel like it belongs as part of bitmap_uploader but rather of a particular customer of bitmap_uploader. For example, pdf_viewer does not care about this constant. https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/gpu_process_transport_factory.cc:153: "mojo-platform-channel-handle")) { nit: constant? Maybe in content_switches.h https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:11: #include "ui/gfx/native_widget_types.h" Nit: is this necessary? https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:15: class SurfaceOzoneCanvas; nit: remove. https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:19: class BitmapUploader; nit: remove. https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:52: static_cast<gfx::AcceleratedWidget>(widget_counter++), What is the purpose of this counter? https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:189: if (!default_context_factory) { Do we need the other context factory if we have a default_context_factory?
https://codereview.chromium.org/1438903002/diff/20001/components/bitmap_uploa... File components/bitmap_uploader/bitmap_uploader.h (right): https://codereview.chromium.org/1438903002/diff/20001/components/bitmap_uploa... components/bitmap_uploader/bitmap_uploader.h:23: extern const char kBitmapUploaderForAcceleratedWidget[]; On 2015/11/13 02:18:02, Fady Samuel wrote: > This constant doesn't feel like it belongs as part of bitmap_uploader but rather > of a particular customer of bitmap_uploader. For example, pdf_viewer does not > care about this constant. It needs to be somewhere that doesn't violate layering. So it can't go in ui/views. Where do you suggest? This was convenient. Aura maybe? https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/gpu_process_transport_factory.cc:153: "mojo-platform-channel-handle")) { On 2015/11/13 02:18:02, Fady Samuel wrote: > nit: constant? Maybe in content_switches.h It doesn't belong there. It requires refactoring mojo_runner_util.h out of src/chrome/browser into somewhere that can be used from content. TODO added. https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:11: #include "ui/gfx/native_widget_types.h" On 2015/11/13 02:18:02, Fady Samuel wrote: > Nit: is this necessary? Done. https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:15: class SurfaceOzoneCanvas; On 2015/11/13 02:18:02, Fady Samuel wrote: > nit: remove. Done. https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:19: class BitmapUploader; On 2015/11/13 02:18:02, Fady Samuel wrote: > nit: remove. Done. https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:52: static_cast<gfx::AcceleratedWidget>(widget_counter++), On 2015/11/13 02:18:02, Fady Samuel wrote: > What is the purpose of this counter? The accelerated widget number. Need a different widget for each PlatformWindow. https://codereview.chromium.org/1438903002/diff/20001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:189: if (!default_context_factory) { On 2015/11/13 02:18:02, Fady Samuel wrote: > Do we need the other context factory if we have a default_context_factory? Not at present. But we will later.
ben@chromium.org changed reviewers: + ben@chromium.org
https://codereview.chromium.org/1438903002/diff/40001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/40001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:24: void EndPaint() override; nit: -> private
https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... content/browser/compositor/gpu_process_transport_factory.cc:153: "mojo-platform-channel-handle")) { On 2015/11/13 03:10:43, rjkroege wrote: > On 2015/11/13 02:18:02, Fady Samuel wrote: > > nit: constant? Maybe in content_switches.h > > It doesn't belong there. It requires refactoring mojo_runner_util.h out of > src/chrome/browser into somewhere that can be used from content. TODO added. I'm going to do this tonight/tomorrow. I'll stuff some state into TLS that can be used to check for being run in the runner.
https://codereview.chromium.org/1438903002/diff/40001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/40001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:24: void EndPaint() override; On 2015/11/13 03:26:52, Ben Goodger (Google) wrote: > nit: -> private Done.
On 2015/11/13 03:29:35, Ben Goodger (Google) wrote: > https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... > File content/browser/compositor/gpu_process_transport_factory.cc (right): > > https://codereview.chromium.org/1438903002/diff/20001/content/browser/composi... > content/browser/compositor/gpu_process_transport_factory.cc:153: > "mojo-platform-channel-handle")) { > On 2015/11/13 03:10:43, rjkroege wrote: > > On 2015/11/13 02:18:02, Fady Samuel wrote: > > > nit: constant? Maybe in content_switches.h > > > > It doesn't belong there. It requires refactoring mojo_runner_util.h out of > > src/chrome/browser into somewhere that can be used from content. TODO added. > > I'm going to do this tonight/tomorrow. I'll stuff some state into TLS that can > be used to check for being run in the runner. Awesome.
lgtm + a couple of other nits. https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... File content/browser/compositor/software_output_device_mus.cc (right): https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... content/browser/compositor/software_output_device_mus.cc:14: #include "ui/gfx/vsync_provider.h" nit: is this necessary? https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:26: void EndPaint() override; nit: indicate what you're overriding above in a comment.
https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:32: static uint32_t widget_counter = 1; nit: accelerated_widget_count. https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:197: bitmap_uploader_.reset(new bitmap_uploader::BitmapUploader(window)); Why does this code have to create BitmapUploader? Can't SoftwareOutputDeviceMus do that?
lgtm with comment https://codereview.chromium.org/1438903002/diff/60001/base/threading/thread_r... File base/threading/thread_restrictions.h (right): https://codereview.chromium.org/1438903002/diff/60001/base/threading/thread_r... base/threading/thread_restrictions.h:222: friend class content::SoftwareOutputDeviceMus; // http://crbug.com/548451 nit: add a comment saying that this is not production code. no need to put a bug there (that's usually tracking removal of this entry, which doesn't really apply here)
The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run
The CQ bit was unchecked by rjkroege@chromium.org
rjkroege@chromium.org changed reviewers: + ccameron@chromium.org - danakj@chromium.org
ccameron@chromium.org: please look at content/browser/compositor/* sky@chromium.org: ptal. https://codereview.chromium.org/1438903002/diff/60001/base/threading/thread_r... File base/threading/thread_restrictions.h (right): https://codereview.chromium.org/1438903002/diff/60001/base/threading/thread_r... base/threading/thread_restrictions.h:222: friend class content::SoftwareOutputDeviceMus; // http://crbug.com/548451 On 2015/11/13 17:17:55, jam wrote: > nit: add a comment saying that this is not production code. no need to put a bug > there (that's usually tracking removal of this entry, which doesn't really apply > here) Done. https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... File content/browser/compositor/software_output_device_mus.cc (right): https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... content/browser/compositor/software_output_device_mus.cc:14: #include "ui/gfx/vsync_provider.h" On 2015/11/13 07:57:34, Fady Samuel wrote: > nit: is this necessary? Done. https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/60001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:26: void EndPaint() override; On 2015/11/13 07:57:34, Fady Samuel wrote: > nit: indicate what you're overriding above in a comment. Done. https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:32: static uint32_t widget_counter = 1; On 2015/11/13 16:24:25, sky wrote: > nit: accelerated_widget_count. Done. https://codereview.chromium.org/1438903002/diff/60001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:197: bitmap_uploader_.reset(new bitmap_uploader::BitmapUploader(window)); On 2015/11/13 16:24:25, sky wrote: > Why does this code have to create BitmapUploader? Can't SoftwareOutputDeviceMus > do that? fwiw, my rationale for building it here went like this: - we need the mojo::Shell and mus::Window to build a BitmapUploader - SoftwareOutputDevice gets only a Compositor instance as a construction argument - the cc instance must have the GpuProcessTransportFactory instance as its ContextProvider or it doesn't draw - I didn't want to do a much larger refactor of ContextProvider et al. to make the mojo shell available from cc's ContextProvider - I didn't want to have view props for the mojo::Shell and mus::Window But maybe that's bad reasoning? I couldn't find a good way to get the mojo::Shell from inside SoftwareOutputDeviceMus. Is there one? Is it better to have two ViewProps.
The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
sky's OOO the rest of the day so I'll lgtm with these nits. re his comment about where to instantiate things. shortly you'll be able to access the shell down in content if you need to, at least on the main thread. at some point i think we should revisit which of these interfaces take shell. i think we should be a bit finer grained about dependency injection. https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:21: class CONTENT_EXPORT SoftwareOutputDeviceMus : public cc::SoftwareOutputDevice { does this need to be CONTENT_EXPORT? https://codereview.chromium.org/1438903002/diff/80001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/80001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:189: if (!default_context_factory) { nit: no braces
https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... content/browser/compositor/gpu_process_transport_factory.cc:156: } Can we get a IsRunningInMojoRunner() similar to the one in chrome/browser/mojo_runner_util.h in content? https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... content/browser/compositor/gpu_process_transport_factory.cc:208: } Likewise.
On 2015/11/13 23:15:42, ccameron wrote: > https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... > File content/browser/compositor/gpu_process_transport_factory.cc (right): > > https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... > content/browser/compositor/gpu_process_transport_factory.cc:156: } > Can we get a IsRunningInMojoRunner() similar to the one in > chrome/browser/mojo_runner_util.h in content? > > https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... > content/browser/compositor/gpu_process_transport_factory.cc:208: } > Likewise. I'll use as soon as https://codereview.chromium.org/1442893002/ lands.
Fair enough -- lgtm
https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... File content/browser/compositor/software_output_device_mus.h (right): https://codereview.chromium.org/1438903002/diff/80001/content/browser/composi... content/browser/compositor/software_output_device_mus.h:21: class CONTENT_EXPORT SoftwareOutputDeviceMus : public cc::SoftwareOutputDevice { On 2015/11/13 23:15:05, Ben Goodger (Google) wrote: > does this need to be CONTENT_EXPORT? Done. https://codereview.chromium.org/1438903002/diff/80001/ui/views/mus/window_tre... File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/1438903002/diff/80001/ui/views/mus/window_tre... ui/views/mus/window_tree_host_mus.cc:189: if (!default_context_factory) { On 2015/11/13 23:15:05, Ben Goodger (Google) wrote: > nit: no braces Done.
The CQ bit was checked by rjkroege@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, jam@chromium.org, ben@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1438903002/#ps100001 (title: "rebase, nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by rjkroege@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, jam@chromium.org, ben@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1438903002/#ps120001 (title: "fix build issues")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rjkroege@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, jam@chromium.org, ben@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1438903002/#ps140001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by rjkroege@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, jam@chromium.org, ben@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1438903002/#ps160001 (title: "rebase, build fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/160001
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Failed to apply the patch.
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c Cr-Commit-Position: refs/heads/master@{#360289}
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/1460593004/ by msramek@chromium.org. The reason for reverting is: Broken compilation: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux....
Message was sent while issue was closed.
Description was changed from ========== p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c Cr-Commit-Position: refs/heads/master@{#360289} ========== to ========== p1 mus+ash chrome renders ui and content This patch forces mus+ash Chrome to software composite the ui and content region into a single bitmap that is uploaded to the mus window server. The approach here is similar to how Chrome paints to X11 when hardware acceleration is not available. BUG=554699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c Cr-Commit-Position: refs/heads/master@{#360289} ==========
The CQ bit was checked by rjkroege@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, jam@chromium.org, ben@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1438903002/#ps180001 (title: "rebased, fixed release build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438903002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438903002/180001
Message was sent while issue was closed.
Committed patchset #10 (id:180001)
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/c109de6120382395cafa9de062710e0f9eed861a Cr-Commit-Position: refs/heads/master@{#360464} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
