Move SkBitmapRegionDecoder to include/android and src/android

Move SkBitmapRegionDecoder to include/android and src/android

This will expose the BitmapRegionDecoder API as a public include
and move the implementation to src.

This makes this code more naturally exposed in Android and easier
to test in DM and nanobench.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/506e19a4c8395178e8da81576b3c37616593e560

[msarett, 2015-11-11 22:12:17]

msarett@google.com changed reviewers:
+ djsollen@google.com, reed@google.com, scroggo@google.com

[mtklein, 2015-11-11 22:24:20]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-11-11 22:24:21]

https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi
File gyp/bench.gypi (right):

https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi#newcode10
gyp/bench.gypi:10: '../src/android',
Probably not needed now that this API is in include/?

https://codereview.chromium.org/1438873002/diff/1/gyp/dm.gypi
File gyp/dm.gypi (right):

https://codereview.chromium.org/1438873002/diff/1/gyp/dm.gypi#newcode11
gyp/dm.gypi:11: '../src/android',
Probably not needed now that this API is in include/?

https://codereview.chromium.org/1438873002/diff/1/gyp/visualbench.gyp
File gyp/visualbench.gyp (right):

https://codereview.chromium.org/1438873002/diff/1/gyp/visualbench.gyp#newcode21
gyp/visualbench.gyp:21: '../src/android',
Probably not needed now that this API is in include/?

[msarett, 2015-11-11 22:33:14]

https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi
File gyp/bench.gypi (right):

https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi#newcode10
gyp/bench.gypi:10: '../src/android',
On 2015/11/11 22:24:21, mtklein wrote:
> Probably not needed now that this API is in include/?

In all three cases it is needed.

get_scale_from_sample_size() is defined in SkBitmapRegionDecoderPriv.h is used
in DM and nanobench.  Amusingly, it is not used in src/android.  It is also used
in src/codec (which happens to have its own identical version of this function
in src/codec/SkCodecPriv.h).

We probably want to put it in one place where it can be accessed everywhere. 
Any suggestions?

[mtklein, 2015-11-11 22:37:28]

On 2015/11/11 at 22:33:14, msarett wrote:
> https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi
> File gyp/bench.gypi (right):
> 
> https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi#newcode10
> gyp/bench.gypi:10: '../src/android',
> On 2015/11/11 22:24:21, mtklein wrote:
> > Probably not needed now that this API is in include/?
> 
> In all three cases it is needed.
> 
> get_scale_from_sample_size() is defined in SkBitmapRegionDecoderPriv.h is used
in DM and nanobench.  Amusingly, it is not used in src/android.  It is also used
in src/codec (which happens to have its own identical version of this function
in src/codec/SkCodecPriv.h).
> 
> We probably want to put it in one place where it can be accessed everywhere. 
Any suggestions?


This?

inline float get_scale_from_sample_size(uint32_t sampleSize) {
    return 1.0f / (float) sampleSize;
}

If that's going to stand on its own as a function, it probably wants some
comments to describe what it means.
It doesn't really explain itself.

Personally, I'd just write 1.0f/sampleSize inline wherever you need it.  That's
probably clearer to see what's going on than
get_scale_from_sample_size(sampleSize).

[mtklein, 2015-11-11 22:38:21]

On 2015/11/11 at 22:37:28, mtklein wrote:
> On 2015/11/11 at 22:33:14, msarett wrote:
> > https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi
> > File gyp/bench.gypi (right):
> > 
> > https://codereview.chromium.org/1438873002/diff/1/gyp/bench.gypi#newcode10
> > gyp/bench.gypi:10: '../src/android',
> > On 2015/11/11 22:24:21, mtklein wrote:
> > > Probably not needed now that this API is in include/?
> > 
> > In all three cases it is needed.
> > 
> > get_scale_from_sample_size() is defined in SkBitmapRegionDecoderPriv.h is
used in DM and nanobench.  Amusingly, it is not used in src/android.  It is also
used in src/codec (which happens to have its own identical version of this
function in src/codec/SkCodecPriv.h).
> > 
> > We probably want to put it in one place where it can be accessed everywhere.
 Any suggestions?
> 
> 
> This?
> 
> inline float get_scale_from_sample_size(uint32_t sampleSize) {
>     return 1.0f / (float) sampleSize;
> }
> 
> If that's going to stand on its own as a function, it probably wants some
comments to describe what it means.
> It doesn't really explain itself.
> 
> Personally, I'd just write 1.0f/sampleSize inline wherever you need it. 
That's probably clearer to see what's going on than
get_scale_from_sample_size(sampleSize).

(Don't let this derail this CL.)

[scroggo, 2015-11-12 01:04:29]

https://codereview.chromium.org/1438873002/diff/1/include/android/SkBRDAlloca...
File include/android/SkBRDAllocator.h (right):

https://codereview.chromium.org/1438873002/diff/1/include/android/SkBRDAlloca...
include/android/SkBRDAllocator.h:8: #ifndef SkBRDAllocator_DEFINED
This is a step towards fixing Android's master-skia branch (for which I uploaded
a CL here: https://codereview.chromium.org/1440883002/).

[dogben, 2015-11-13 13:05:14]

benjaminwagner@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2015-11-13 13:05:15]

Any chance this can get checked in today?

[reed1, 2015-11-13 13:48:46]

api lgtm

[scroggo, 2015-11-13 13:50:20]

On 2015/11/13 13:05:15, Ben Wagner wrote:
> Any chance this can get checked in today?

LGTM, with or without mtklein's suggested changes.

Derek or Mike, this will still need API approval

[msarett, 2015-11-13 13:58:49]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-11-13 13:58:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438873002/20001

[commit-bot: I haz the power, 2015-11-13 14:11:12]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/506e19a4c8395178e8da81576b3c37616593e560