src/x64/lithium-codegen-x64.cc - Issue 14387008: Fix beyond-heap load on x64 Crankshafted StringCharFromCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 14387008: Fix beyond-heap load on x64 Crankshafted StringCharFromCode (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 1ff2bd6ebc4e6985ee4bae946769a0c8e691cfbd..70c71368c1339e36d08936c3fcfe88d57fe31df9 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -4384,6 +4384,7 @@ void LCodeGen::DoStringCharFromCode(LStringCharFromCode* instr) {

__ cmpl(char_code, Immediate(String::kMaxOneByteCharCode));

__ j(above, deferred->entry());

+ __ movsxlq(char_code, char_code);

__ LoadRoot(result, Heap::kSingleCharacterStringCacheRootIndex);

__ movq(result, FieldOperand(result,

char_code, times_pointer_size,

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-235311.js » ('j') | no next file with comments »