Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 14387008: Fix beyond-heap load on x64 Crankshafted StringCharFromCode (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-235311.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4366 matching lines...) Expand 10 before | Expand all | Expand 10 after
4377 DeferredStringCharFromCode* deferred = 4377 DeferredStringCharFromCode* deferred =
4378 new(zone()) DeferredStringCharFromCode(this, instr); 4378 new(zone()) DeferredStringCharFromCode(this, instr);
4379 4379
4380 ASSERT(instr->hydrogen()->value()->representation().IsInteger32()); 4380 ASSERT(instr->hydrogen()->value()->representation().IsInteger32());
4381 Register char_code = ToRegister(instr->char_code()); 4381 Register char_code = ToRegister(instr->char_code());
4382 Register result = ToRegister(instr->result()); 4382 Register result = ToRegister(instr->result());
4383 ASSERT(!char_code.is(result)); 4383 ASSERT(!char_code.is(result));
4384 4384
4385 __ cmpl(char_code, Immediate(String::kMaxOneByteCharCode)); 4385 __ cmpl(char_code, Immediate(String::kMaxOneByteCharCode));
4386 __ j(above, deferred->entry()); 4386 __ j(above, deferred->entry());
4387 __ movsxlq(char_code, char_code);
4387 __ LoadRoot(result, Heap::kSingleCharacterStringCacheRootIndex); 4388 __ LoadRoot(result, Heap::kSingleCharacterStringCacheRootIndex);
4388 __ movq(result, FieldOperand(result, 4389 __ movq(result, FieldOperand(result,
4389 char_code, times_pointer_size, 4390 char_code, times_pointer_size,
4390 FixedArray::kHeaderSize)); 4391 FixedArray::kHeaderSize));
4391 __ CompareRoot(result, Heap::kUndefinedValueRootIndex); 4392 __ CompareRoot(result, Heap::kUndefinedValueRootIndex);
4392 __ j(equal, deferred->entry()); 4393 __ j(equal, deferred->entry());
4393 __ bind(deferred->exit()); 4394 __ bind(deferred->exit());
4394 } 4395 }
4395 4396
4396 4397
(...skipping 1298 matching lines...) Expand 10 before | Expand all | Expand 10 after
5695 FixedArray::kHeaderSize - kPointerSize)); 5696 FixedArray::kHeaderSize - kPointerSize));
5696 __ bind(&done); 5697 __ bind(&done);
5697 } 5698 }
5698 5699
5699 5700
5700 #undef __ 5701 #undef __
5701 5702
5702 } } // namespace v8::internal 5703 } } // namespace v8::internal
5703 5704
5704 #endif // V8_TARGET_ARCH_X64 5705 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-235311.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698