API changes to GrTextureAdjuster.

API changes to GrTextureAdjuster.

These changes are to facilitate converting SkGpuDevice::drawTextureAdjuster to SkGpuDevice::drawTextureProducer.

Make constraint rect relative to content area

Store dimensions in GrTextureProducer

Make originalTexture() protected.

Remove getContentArea()

Provide pre-normalized texture matrix to GrTextureAdjuster::createFragmentProcessor. Define it to be be relative to content area.

Committed: https://skia.googlesource.com/skia/+/3aa5fce54e1d8f4a682eaf6446fa73df962b3778

[bsalomon, 2015-11-11 22:29:08]

Description was changed from

==========
API changes to GrTextureAdjuster.

These changes are to facilitate converting SkGpuDevice::drawTextureAdjuster to
SkGpuDevice::drawTextureProducer.

Make constraint rect relative to content area

Store dimensions in GrTextureProducer

Make originalTexture() protected.

Remove getContentArea()

Defer texture matrix computation for GrTextureAdjuster::createFragmentProcessor

BUG=skia:
==========

to

==========
API changes to GrTextureAdjuster.

These changes are to facilitate converting SkGpuDevice::drawTextureAdjuster to
SkGpuDevice::drawTextureProducer.

Make constraint rect relative to content area

Store dimensions in GrTextureProducer

Make originalTexture() protected.

Remove getContentArea()

Provide pre-normalized texture matrix to
GrTextureAdjuster::createFragmentProcessor. Define it to be be relative to
content area.
==========

[bsalomon, 2015-11-11 22:29:08]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-11-11 22:32:40]

The point here is mostly to hide any knowledge of the content area or the
original texture from SkGpuDevice::drawTextureAdjuster so that it can also be
used for GrTextureMakers.

[robertphillips, 2015-11-11 22:44:04]

lgtm

https://codereview.chromium.org/1438663004/diff/60001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1438663004/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:111: *                                        
constraint rect is relative to the content area.
and is in texel coordinates ?

[bsalomon, 2015-11-12 00:40:42]

https://codereview.chromium.org/1438663004/diff/60001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1438663004/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:111: *                                        
constraint rect is relative to the content area.
On 2015/11/11 22:44:04, robertphillips wrote:
> and is in texel coordinates ?

In a follow-up CL this function gets promoted to the base class. These comments
need to be worded then, anyway.

[bsalomon, 2015-11-12 17:16:54]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 17:17:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438663004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438663004/60001

[commit-bot: I haz the power, 2015-11-12 17:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 17:28:22]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2015-11-12 17:59:01]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-11-12 17:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438663004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438663004/60001

[commit-bot: I haz the power, 2015-11-12 17:59:46]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3aa5fce54e1d8f4a682eaf6446fa73df962b3778