Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 1438453002: Use Feature directly in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/class_hierarchy.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend_impact.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend_impact.dart b/pkg/compiler/lib/src/js_backend/backend_impact.dart
index d4b992a11a30fa770801eb4b3ac95a69fca28f74..265566e24e2d084b604a6733ed1550d339ac7f6e 100644
--- a/pkg/compiler/lib/src/js_backend/backend_impact.dart
+++ b/pkg/compiler/lib/src/js_backend/backend_impact.dart
@@ -200,7 +200,35 @@ class BackendImpacts {
BackendImpact get stringInterpolation => new BackendImpact(
staticUses: [
- helpers.stringInterpolationHelper]);
+ helpers.stringInterpolationHelper],
+ otherImpacts: [
+ needsString('Strings are created.')]);
+
+ BackendImpact get stringJuxtaposition {
+ return needsString('String.concat is used.');
+ }
+
+ // TODO(johnniwinther): Point to to the JavaScript classes instead of the Dart
+ // classes in these impacts.
+ BackendImpact get nullLiteral => new BackendImpact(
+ instantiatedClasses: [
+ coreClasses.nullClass]);
+
+ BackendImpact get boolLiteral => new BackendImpact(
+ instantiatedClasses: [
+ coreClasses.boolClass]);
+
+ BackendImpact get intLiteral => new BackendImpact(
+ instantiatedClasses: [
+ coreClasses.intClass]);
+
+ BackendImpact get doubleLiteral => new BackendImpact(
+ instantiatedClasses: [
+ coreClasses.doubleClass]);
+
+ BackendImpact get stringLiteral => new BackendImpact(
+ instantiatedClasses: [
+ coreClasses.stringClass]);
BackendImpact get catchStatement => new BackendImpact(
staticUses: [
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/class_hierarchy.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698