Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438343002: Remove deprecated ScopedVector usage from ui/ozone and ui/events/ozone (Closed)

Created:
5 years, 1 month ago by spang
Modified:
5 years, 1 month ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ScopedVector usage from ui/ozone and ui/events/ozone Also add some missing scoped_ptr in GesturePropertyProvider, and use the range-based for loop syntax where appropriate. BUG=554289 Committed: https://crrev.com/a75b0b292f95229b6a54bb3bb127eaa985c46689 Cr-Commit-Position: refs/heads/master@{#360662}

Patch Set 1 #

Total comments: 2

Patch Set 2 : structify HDCI & fix uninit controller #

Patch Set 3 : no more warnings #

Patch Set 4 : remove HDCI stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -180 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.h View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 2 3 11 chunks +43 lines, -41 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/crtc_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc View 1 2 3 6 chunks +25 lines, -25 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 2 3 10 chunks +33 lines, -35 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 13 chunks +22 lines, -25 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host_manager.cc View 1 2 3 5 chunks +11 lines, -10 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_overlay_candidates_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
spang
5 years, 1 month ago (2015-11-12 23:08:26 UTC) #2
dnicoara
https://codereview.chromium.org/1438343002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc (right): https://codereview.chromium.org/1438343002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc#newcode1271 ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:1271: return property; Don't you need to do "property.Pass()" anymore?
5 years, 1 month ago (2015-11-13 19:35:48 UTC) #3
spang
https://codereview.chromium.org/1438343002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc (right): https://codereview.chromium.org/1438343002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc#newcode1271 ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:1271: return property; On 2015/11/13 19:35:48, dnicoara wrote: > Don't ...
5 years, 1 month ago (2015-11-13 19:49:13 UTC) #4
spang
PTAL. I removed the bits that still need more C++11 to be allowed.
5 years, 1 month ago (2015-11-19 19:21:49 UTC) #5
dnicoara
lgtm
5 years, 1 month ago (2015-11-19 19:36:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438343002/60001
5 years, 1 month ago (2015-11-19 19:40:13 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-19 21:10:02 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 21:11:32 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a75b0b292f95229b6a54bb3bb127eaa985c46689
Cr-Commit-Position: refs/heads/master@{#360662}

Powered by Google App Engine
This is Rietveld 408576698