Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: ui/ozone/platform/drm/host/drm_display_host_manager.cc

Issue 1438343002: Remove deprecated ScopedVector usage from ui/ozone and ui/events/ozone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove HDCI stuff Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/host/drm_display_host_manager.cc
diff --git a/ui/ozone/platform/drm/host/drm_display_host_manager.cc b/ui/ozone/platform/drm/host/drm_display_host_manager.cc
index 0809e0444367984e9b83ddc20c713492687b41fa..f0b86c1f06f39d9a40acc392ead2d41dd1c6ff81 100644
--- a/ui/ozone/platform/drm/host/drm_display_host_manager.cc
+++ b/ui/ozone/platform/drm/host/drm_display_host_manager.cc
@@ -98,7 +98,7 @@ class FindDrmDisplayHostById {
explicit FindDrmDisplayHostById(int64_t display_id)
: display_id_(display_id) {}
- bool operator()(const DrmDisplayHost* display) const {
+ bool operator()(const scoped_ptr<DrmDisplayHost>& display) const {
return display->snapshot()->display_id() == display_id_;
}
@@ -139,11 +139,11 @@ DrmDisplayHostManager::DrmDisplayHostManager(
GetAvailableDisplayControllerInfos(primary_drm_device_handle_->fd());
has_dummy_display_ = !display_infos.empty();
for (size_t i = 0; i < display_infos.size(); ++i) {
- displays_.push_back(new DrmDisplayHost(
+ displays_.push_back(make_scoped_ptr(new DrmDisplayHost(
proxy_, CreateDisplaySnapshotParams(display_infos[i],
primary_drm_device_handle_->fd(), 0,
gfx::Point()),
- true /* is_dummy */));
+ true /* is_dummy */)));
}
}
@@ -158,7 +158,7 @@ DrmDisplayHost* DrmDisplayHostManager::GetDisplay(int64_t display_id) {
if (it == displays_.end())
return nullptr;
- return *it;
+ return it->get();
}
void DrmDisplayHostManager::AddDelegate(DrmNativeDisplayDelegate* delegate) {
@@ -367,17 +367,18 @@ bool DrmDisplayHostManager::OnMessageReceived(const IPC::Message& message) {
void DrmDisplayHostManager::OnUpdateNativeDisplays(
const std::vector<DisplaySnapshot_Params>& params) {
- ScopedVector<DrmDisplayHost> old_displays(displays_.Pass());
+ std::vector<scoped_ptr<DrmDisplayHost>> old_displays;
+ displays_.swap(old_displays);
for (size_t i = 0; i < params.size(); ++i) {
auto it = std::find_if(old_displays.begin(), old_displays.end(),
FindDrmDisplayHostById(params[i].display_id));
if (it == old_displays.end()) {
- displays_.push_back(
- new DrmDisplayHost(proxy_, params[i], false /* is_dummy */));
+ displays_.push_back(make_scoped_ptr(
+ new DrmDisplayHost(proxy_, params[i], false /* is_dummy */)));
} else {
(*it)->UpdateDisplaySnapshot(params[i]);
- displays_.push_back(*it);
- old_displays.weak_erase(it);
+ displays_.push_back(std::move(*it));
+ old_displays.erase(it);
}
}
@@ -461,7 +462,7 @@ void DrmDisplayHostManager::OnRelinquishDisplayControl(bool status) {
void DrmDisplayHostManager::RunUpdateDisplaysCallback(
const GetDisplaysCallback& callback) const {
std::vector<DisplaySnapshot*> snapshots;
- for (auto* display : displays_)
+ for (const auto& display : displays_)
snapshots.push_back(display->snapshot());
callback.Run(snapshots);
« no previous file with comments | « ui/ozone/platform/drm/host/drm_display_host_manager.h ('k') | ui/ozone/platform/drm/host/drm_overlay_candidates_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698