Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 14383009: Revert 196479 "Revert 196446 "Make touch drag drop and touch edi..." (Closed)

Created:
7 years, 8 months ago by varunjain
Modified:
7 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 196479 "Revert 196446 "Make touch drag drop and touch edi..." The reason for the build break due to which the original patch was reverted has been rectified in https://codereview.chromium.org/14113034/ No changes required to the original CL. > Revert 196446 "Make touch drag drop and touch editing flags tri-..." > > [Reason for revert: Caused repeatable ASAN failures on ChromiumOS bots, > in the tests WebViewTest.Shim and WebViewTest.NewWindow. The failures > indicated a Heap-Use-After-Free condition in > TouchEditableImplAura::AttachToView] > > > Make touch drag drop and touch editing flags tri-state and turn them on by > > default on chromeos. > > > > BUG=115237, 168162 > > > > Review URL: https://chromiumcodereview.appspot.com/14286004 > > TBR=varunjain@chromium.org > > Review URL: https://codereview.chromium.org/14439009 TBR=nick@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -25 lines) Patch
MM trunk/src/chrome/browser/about_flags.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/content/browser/web_contents/touch_editable_impl_aura.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ui/base/ui_base_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ui/base/ui_base_switches.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A + trunk/src/ui/base/ui_base_switches_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/base/ui_base_switches_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ui/views/controls/textfield/native_textfield_views.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/ui/views/touchui/touch_selection_controller_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
MM trunk/src/ui/views/view.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
varunjain
7 years, 8 months ago (2013-04-26 19:19:51 UTC) #1
ncarter (slow)
lgtm
7 years, 8 months ago (2013-04-26 19:26:38 UTC) #2
varunjain
7 years, 7 months ago (2013-04-29 17:22:44 UTC) #3
On 2013/04/26 19:26:38, ncarter wrote:
> lgtm

Closing this as I have relanded this as a new CL so I could run trybots on it:
https://chromiumcodereview.appspot.com/14283013/

Powered by Google App Engine
This is Rietveld 408576698