Issue 14439009: Revert 196446 "Make touch drag drop and touch editing flags tri-..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14439009: Revert 196446 "Make touch drag drop and touch editing flags tri-..." (Closed)

Created:
7 years, 8 months ago by ncarter (slow)

Modified:
7 years, 8 months ago

Reviewers:
varunjain

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 196446 "Make touch drag drop and touch editing flags tri-..." [Reason for revert: Caused repeatable ASAN failures on ChromiumOS bots, in the tests WebViewTest.Shim and WebViewTest.NewWindow. The failures indicated a Heap-Use-After-Free condition in TouchEditableImplAura::AttachToView] > Make touch drag drop and touch editing flags tri-state and turn them on by > default on chromeos. > > BUG=115237, 168162 > > Review URL: https://chromiumcodereview.appspot.com/14286004 TBR=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196479

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -84 lines)			Patch
MM	trunk/src/chrome/browser/about_flags.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
MM	trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/web_contents/touch_editable_impl_aura.cc	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/render_view_impl.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/ui/base/ui_base_switches.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/base/ui_base_switches.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	trunk/src/ui/base/ui_base_switches_util.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	trunk/src/ui/base/ui_base_switches_util.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	trunk/src/ui/ui.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/controls/textfield/native_textfield_views.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/touchui/touch_selection_controller_impl.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/view.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r196479.