Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1438083003: Run testVisualStateCallbackWaitsForContentsToBeOnScreen in single process mode only. (Closed)

Created:
5 years, 1 month ago by Tobias Sargeant
Modified:
5 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run testVisualStateCallbackWaitsForContentsToBeOnScreen in single process mode only. This test requires software draws, so presently it only runs in single process mode. BUG=554655 Committed: https://crrev.com/96bfbf1f0767e672aa9dcd419016ecdb126184dc Cr-Commit-Position: refs/heads/master@{#359211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tobias Sargeant
5 years, 1 month ago (2015-11-11 23:32:49 UTC) #2
mnaganov (inactive)
lgtm
5 years, 1 month ago (2015-11-11 23:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438083003/1
5 years, 1 month ago (2015-11-12 00:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 02:41:21 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96bfbf1f0767e672aa9dcd419016ecdb126184dc
Cr-Commit-Position: refs/heads/master@{#359211}

Powered by Google App Engine
This is Rietveld 408576698