Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

Issue 1438083003: Run testVisualStateCallbackWaitsForContentsToBeOnScreen in single process mode only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
index 44004d4305946495b1ce64b5b97bed893c3d8b98..d85737e930e4974d98154bf802f318797e5472ba 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
@@ -7,7 +7,6 @@ package org.chromium.android_webview.test;
import android.graphics.Bitmap;
import android.graphics.Color;
import android.graphics.Rect;
-import android.test.FlakyTest;
import android.test.suitebuilder.annotation.SmallTest;
import android.util.Base64;
@@ -136,10 +135,10 @@ public class VisualStateTest extends AwTestBase {
ch.waitForCallback(chCount);
}
- @FlakyTest
- // crbug.com/554655
- // @Feature({"AndroidWebView"})
- // @SmallTest
+ @Feature({"AndroidWebView"})
+ @SmallTest
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testVisualStateCallbackWaitsForContentsToBeOnScreen() throws Throwable {
// This test loads a page with a blue background color. It then waits for the DOM tree
// in blink to contain the contents of the blue page (which happens when the onPageFinished
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698