Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: build/common.gypi

Issue 1438053002: Enable template checking for the clang plugin everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gypi Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 67fc8e5b554a3bad4a41115cada9f3a0f95b4921..9f845b174706f87238d80c69a4a5a38b517d93c7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2212,13 +2212,8 @@
# no need to load it dynamically.
'clang_dynlib_flags%': '',
}],
- # https://crbug.com/441916
- ['OS=="android" or OS=="linux" or OS=="mac"', {
- 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ',
- }, { # OS != "linux"
- 'clang_plugin_args%': ''
- }],
],
+ 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ',
},
# If you change these, also change build/config/clang/BUILD.gn.
'clang_chrome_plugins_flags%':
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698