Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Side by Side Diff: build/common.gypi

Issue 1438053002: Enable template checking for the clang plugin everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gypi Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2205 'clang_lib_path%': '<!(cd <(DEPTH) && pwd -P)/third_party/ll vm-build/Release+Asserts/lib/libFindBadConstructs.so', 2205 'clang_lib_path%': '<!(cd <(DEPTH) && pwd -P)/third_party/ll vm-build/Release+Asserts/lib/libFindBadConstructs.so',
2206 }], 2206 }],
2207 ], 2207 ],
2208 }, 2208 },
2209 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ', 2209 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ',
2210 }, { # OS == "win" 2210 }, { # OS == "win"
2211 # On Windows, the plugin is built directly into clang, so there's 2211 # On Windows, the plugin is built directly into clang, so there's
2212 # no need to load it dynamically. 2212 # no need to load it dynamically.
2213 'clang_dynlib_flags%': '', 2213 'clang_dynlib_flags%': '',
2214 }], 2214 }],
2215 # https://crbug.com/441916
2216 ['OS=="android" or OS=="linux" or OS=="mac"', {
2217 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xc lang check-templates ',
2218 }, { # OS != "linux"
2219 'clang_plugin_args%': ''
2220 }],
2221 ], 2215 ],
2216 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ',
2222 }, 2217 },
2223 # If you change these, also change build/config/clang/BUILD.gn. 2218 # If you change these, also change build/config/clang/BUILD.gn.
2224 'clang_chrome_plugins_flags%': 2219 'clang_chrome_plugins_flags%':
2225 '<(clang_dynlib_flags)' 2220 '<(clang_dynlib_flags)'
2226 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' , 2221 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' ,
2227 }], 2222 }],
2228 ['asan==1 or msan==1 or lsan==1 or tsan==1', { 2223 ['asan==1 or msan==1 or lsan==1 or tsan==1', {
2229 'clang%': 1, 2224 'clang%': 1,
2230 'use_allocator%': 'none', 2225 'use_allocator%': 'none',
2231 'use_sanitizer_options%': 1, 2226 'use_sanitizer_options%': 1,
(...skipping 4076 matching lines...) Expand 10 before | Expand all | Expand 10 after
6308 # settings in target dicts. SYMROOT is a special case, because many other 6303 # settings in target dicts. SYMROOT is a special case, because many other
6309 # Xcode variables depend on it, including variables such as 6304 # Xcode variables depend on it, including variables such as
6310 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6305 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6311 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6306 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6312 # files to appear (when present) in the UI as actual files and not red 6307 # files to appear (when present) in the UI as actual files and not red
6313 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6308 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6314 # and therefore SYMROOT, needs to be set at the project level. 6309 # and therefore SYMROOT, needs to be set at the project level.
6315 'SYMROOT': '<(DEPTH)/xcodebuild', 6310 'SYMROOT': '<(DEPTH)/xcodebuild',
6316 }, 6311 },
6317 } 6312 }
OLDNEW
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698