Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1438053002: Enable template checking for the clang plugin everywhere. (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable template checking for the clang plugin everywhere. This enables the plugin to check templated classes for the following things: - Refcounted types have private destructors. - WeakPtrFactory members are the last members BUG=441916 Committed: https://crrev.com/33761b490534b36a0da1bd413bd29bd2edb3ac77 Cr-Commit-Position: refs/heads/master@{#359258}

Patch Set 1 #

Patch Set 2 : fix gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -6 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
Trying to close out some old TODOs, assuming this compiles. It looks like https://llvm.org/bugs/show_bug.cgi?id=21942 is ...
5 years, 1 month ago (2015-11-11 23:33:57 UTC) #2
Nico
lgtm if it builds a follow-up can now remove the flag from the plugin, right?
5 years, 1 month ago (2015-11-11 23:36:51 UTC) #3
dcheng
On 2015/11/11 at 23:36:51, thakis wrote: > lgtm if it builds > > a follow-up ...
5 years, 1 month ago (2015-11-12 03:46:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438053002/20001
5 years, 1 month ago (2015-11-12 03:48:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 04:24:46 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:04:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33761b490534b36a0da1bd413bd29bd2edb3ac77
Cr-Commit-Position: refs/heads/master@{#359258}

Powered by Google App Engine
This is Rietveld 408576698